Skip to content

chore: Type safety #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 157 commits into from
Dec 3, 2025
Merged

chore: Type safety #3902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
157 commits
Select commit Hold shift + click to select a range
e0067b0
feat: started
ErikPre Nov 4, 2025
dbfc069
feat: more typing and fix
ErikPre Nov 4, 2025
79bc2bf
feat: finished fwconfig_import
ErikPre Nov 4, 2025
4f5633a
feat: finished fwconfig_import
ErikPre Nov 4, 2025
9913528
feat: finished fwconfig_import_object
ErikPre Nov 5, 2025
86901c2
wip: fwconfig_import_rule typing
ErikPre Nov 6, 2025
ee28fc4
wip: fwconfig_import_rule typing
ErikPre Nov 6, 2025
f0ed1ea
feat: fix some stuff
ErikPre Nov 7, 2025
1610408
feat: fix more stuff
ErikPre Nov 7, 2025
57e6869
feat: stuff
ErikPre Nov 7, 2025
f744866
Merge branch 'importer-rework' into chore/type-safety
ErikPre Nov 7, 2025
b7d6681
feat: Import only types
ErikPre Nov 7, 2025
a253bde
feat: additional typing
ErikPre Nov 7, 2025
a3a5f09
feat: typed fwo_log
ErikPre Nov 7, 2025
4556421
wip: fwconfig_import_rule
ErikPre Nov 8, 2025
cd5c98e
feat: fwconfig_import_rule typing finished
ErikPre Nov 8, 2025
2c0b067
feat: finished all models
ErikPre Nov 9, 2025
ba71e60
wip: typing
ErikPre Nov 9, 2025
ed2df50
fix: minor changes
ErikPre Nov 9, 2025
5a4999c
feat: more typing
ErikPre Nov 9, 2025
ba48a91
Merge remote-tracking branch 'CactuseSecurity/importer-rework' into c…
Y4nnikH Nov 10, 2025
5f1bded
fix(importer): incorrect types and imports
Y4nnikH Nov 10, 2025
38a8a7d
wip: model controller typing
ErikPre Nov 10, 2025
d40494c
feat: model_controller typing finished
ErikPre Nov 10, 2025
e3c2281
feat: common.py typing
ErikPre Nov 10, 2025
c4a3307
feat: typing finished
ErikPre Nov 10, 2025
c79107e
feat: asa typing finished
ErikPre Nov 10, 2025
63fdb51
fix: circular import
ErikPre Nov 10, 2025
9cf9937
Merge branch 'importer-rework' into chore/type-safety
ErikPre Nov 10, 2025
a3f587c
wip: checkpoint typing
ErikPre Nov 11, 2025
a104348
chore: use python models where possible and replace all Optional with…
ErikPre Nov 11, 2025
4cb5cfa
wip: checkpoint
ErikPre Nov 11, 2025
cee9e63
wip: checkpoint
ErikPre Nov 11, 2025
fffd0b8
feat: cp_rule
ErikPre Nov 11, 2025
7e05454
feat: checkpoint typing
ErikPre Nov 11, 2025
e9183e1
fix(importer): import path
Y4nnikH Nov 12, 2025
33207ea
Merge remote-tracking branch 'upstream/importer-rework' into chore/ty…
Laennart Nov 12, 2025
7dcbb95
fix: ASA types
Laennart Nov 12, 2025
d0ac4f6
refactor: Azure types
Laennart Nov 12, 2025
11f4477
refactor: Cisco firepower domain
Laennart Nov 12, 2025
07053f9
refactor: Dummy router management types
Laennart Nov 12, 2025
fcc6b26
refactor: Revert azure change
Laennart Nov 12, 2025
ce5d155
fix: Checkpoint login
Laennart Nov 13, 2025
2d9d551
wip: fmgr
ErikPre Nov 14, 2025
bdcf2b6
wip: fmgr
ErikPre Nov 15, 2025
932fe22
feat: fmgr
ErikPre Nov 15, 2025
a7d62e8
wip: Cleanup
ErikPre Nov 15, 2025
31be18f
Merge branch 'importer-rework' into chore/type-safety
Y4nnikH Nov 17, 2025
85ab433
wip(importer): prepare service provider to handle necessary data vali…
Y4nnikH Nov 17, 2025
3e66d67
wip: fOS
ErikPre Nov 17, 2025
6313b34
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 17, 2025
abb9145
wip: fOS
ErikPre Nov 18, 2025
2225324
feat: fOS
ErikPre Nov 18, 2025
6e1a89f
feat: main-loop cleanup
ErikPre Nov 19, 2025
bdc1245
feat: cleanup
ErikPre Nov 19, 2025
4b9ef4a
feat: typing
ErikPre Nov 19, 2025
2da32ef
fix: cp imports
ErikPre Nov 19, 2025
300a915
fix: fmgr imports
ErikPre Nov 19, 2025
606e87f
feat: main-loop
ErikPre Nov 19, 2025
a04434e
fix: remove debug
ErikPre Nov 19, 2025
5e5506f
refactor(importer): massive sonarqube offensive
Y4nnikH Nov 19, 2025
c16a0bd
Merge remote-tracking branch 'CactuseSecurity/importer-rework' into c…
Y4nnikH Nov 20, 2025
441e37d
fix: Sonarcube offensive
ErikPre Nov 20, 2025
e63fd8c
fix: Sonarcube offensive
ErikPre Nov 20, 2025
828a503
fix(importer): parameter and logic errors
Y4nnikH Nov 20, 2025
813dc50
Revert "fix: Sonarcube offensive"
ErikPre Nov 20, 2025
071443a
Revert "fix: Sonarcube offensive"
ErikPre Nov 20, 2025
e2f0b0c
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 20, 2025
6f61012
fix: sonarqube issues
Y4nnikH Nov 20, 2025
a40ac6f
fix: Sonarcube Offensive
ErikPre Nov 20, 2025
ecf0a08
fix: Sonarcube Offensive
ErikPre Nov 20, 2025
c946c25
feat: main loop
ErikPre Nov 20, 2025
ed89c34
fix: sonarqube
Y4nnikH Nov 20, 2025
cad197b
feat: service provider
ErikPre Nov 20, 2025
355324c
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 20, 2025
8533d40
feat: Mainloop and common
ErikPre Nov 20, 2025
74759ae
feat: import-main-loop and import-mgm rewrite
ErikPre Nov 20, 2025
985ae78
wip: snake Case everywhere but for class names
ErikPre Nov 21, 2025
5bc0b58
wip: deleting unused functions
ErikPre Nov 21, 2025
380935b
wip: snake case
ErikPre Nov 21, 2025
5725997
wip: Logger rewrite for globals avoidment
ErikPre Nov 21, 2025
6a3f588
feat: added exception for Logger
ErikPre Nov 21, 2025
3f03f70
wip: logger using
ErikPre Nov 21, 2025
35ec8ed
refactor: Unlocking import
Laennart Nov 21, 2025
6211295
feat: Better Logger and removed this global with additional many Bugs
ErikPre Nov 21, 2025
88c2844
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 21, 2025
a7a5d8f
feat: removed unused parameter
ErikPre Nov 21, 2025
ea2c686
fix: Merge
Laennart Nov 21, 2025
685bb64
refactor: vars
Laennart Nov 21, 2025
1485dc8
refactor: Error count and naming
Laennart Nov 21, 2025
ca67cc5
refactor: Error counts
Laennart Nov 21, 2025
d28f2fa
feat: change stuff
ErikPre Nov 25, 2025
642df05
feat: snake case and unused parameters
ErikPre Nov 25, 2025
07b6bb9
feat: more snake case and additional cleanup
ErikPre Nov 25, 2025
08cf72b
feat: more snake case and additional cleanup
ErikPre Nov 25, 2025
c6a28f9
fix: syntax
ErikPre Nov 25, 2025
dd7af83
fix: fixes
ErikPre Nov 25, 2025
3a538a2
wip: Refactor Error count
Laennart Nov 25, 2025
febead3
Merge remote-tracking branch 'origin/chore/type-safety' into chore/ty…
Laennart Nov 25, 2025
000c230
fix: Errors
Laennart Nov 25, 2025
6d9106d
fix: Cleanup
Laennart Nov 25, 2025
21f3101
refactor: Snake case
Laennart Nov 25, 2025
5353caf
refactor: Snake case
Laennart Nov 25, 2025
ded8021
refactor: Typing
Laennart Nov 25, 2025
e3c71b3
fix: global state
ErikPre Nov 25, 2025
8cd1a65
refactor: Management
Laennart Nov 25, 2025
a22d812
Merge remote-tracking branch 'origin/chore/type-safety' into chore/ty…
Laennart Nov 25, 2025
4c8b617
fix: Models
Laennart Nov 25, 2025
184cceb
fix: config model
Laennart Nov 25, 2025
1ee9809
fix: import
ErikPre Nov 25, 2025
2ff75d7
fix: Pydantic (de-)serialization
Laennart Nov 25, 2025
6a81430
feat: Models
ErikPre Nov 25, 2025
7a24798
Merge remote-tracking branch 'CactuseSecurity/importer-rework' into c…
Y4nnikH Nov 26, 2025
a190e23
feat: small changes
ErikPre Nov 26, 2025
4524576
fix: debug
ErikPre Nov 26, 2025
3c55009
fix: made better
ErikPre Nov 26, 2025
60d1ad5
fix: debug level usage
ErikPre Nov 26, 2025
2e9a9e8
fix: Import
ErikPre Nov 26, 2025
241f742
refactor: sonarqube complexities
Y4nnikH Nov 27, 2025
442efeb
refactor: management model to use snake case
Y4nnikH Nov 27, 2025
74a1837
feat: some sonarcube fixes
ErikPre Nov 27, 2025
1b44015
refactor: sonarqube issues
Y4nnikH Nov 27, 2025
234f0b9
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
Y4nnikH Nov 27, 2025
8439720
refactor: sonarqube issues
Y4nnikH Nov 27, 2025
1de64bc
fix: model dump for debug
ErikPre Nov 27, 2025
62fbe47
refactor: sonarqube issues
Y4nnikH Nov 27, 2025
097760c
refactor: sonarqube issues
Y4nnikH Nov 27, 2025
47d3355
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
Y4nnikH Nov 27, 2025
1ef694a
fix: import
ErikPre Nov 27, 2025
22f5ef3
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 27, 2025
9408059
test: fix tests
Y4nnikH Nov 28, 2025
2581499
feat: Interface for importer modules
ErikPre Nov 28, 2025
6ef471e
fix: sonarcube issues
ErikPre Nov 28, 2025
3c522b4
fix: update FWOLogger __new__ method parameter for type safety
ErikPre Nov 28, 2025
f78f3d3
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Nov 28, 2025
251f8d1
test: fix test
Y4nnikH Nov 28, 2025
1c0f63d
fix: import loop
ErikPre Nov 28, 2025
115f580
fix: non error, error
ErikPre Nov 28, 2025
8a06365
fix: non error, error and more pretty
ErikPre Nov 28, 2025
cac62fe
fix: debug logging for unparsable rulebase
ErikPre Nov 28, 2025
c25e97c
refactor: remove unused, duplicate function
Y4nnikH Dec 2, 2025
4cfb34e
refactor: restructure native import modules and remove non-functionin…
Y4nnikH Dec 2, 2025
c76ef10
fix: asa import
Y4nnikH Dec 2, 2025
9c1d183
fix: sonar cube issues
ErikPre Dec 2, 2025
fa69d45
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Dec 2, 2025
35c164f
refactor: sonarqube and other issues
Y4nnikH Dec 2, 2025
ed4c97c
Merge remote-tracking branch 'Laennart/chore/type-safety' into chore/…
Y4nnikH Dec 2, 2025
a00c3cc
fix: more sonarcube
ErikPre Dec 2, 2025
1a56dbe
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Dec 2, 2025
98755ba
refactor: remove unused function parameter
Y4nnikH Dec 2, 2025
743379f
feat: change waiting log to info
ErikPre Dec 2, 2025
10092dc
Merge branch 'chore/type-safety' of https://github.com/Laennart/firew…
ErikPre Dec 2, 2025
feef4ce
feat: sonar cube complexity in main loop
ErikPre Dec 2, 2025
bd25cc0
fix: sonar cube
ErikPre Dec 2, 2025
10e1c7a
fix: last sonar cube issues
ErikPre Dec 2, 2025
5dd25a5
fix: incorrect error log
Y4nnikH Dec 2, 2025
8de4ebe
Merge remote-tracking branch 'CactuseSecurity/importer-rework' into c…
Y4nnikH Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
992 changes: 0 additions & 992 deletions roles/importer/files/importer/CACTUS/FWORCH.pm
View file
Open in desktop

This file was deleted.

1,332 changes: 0 additions & 1,332 deletions roles/importer/files/importer/CACTUS/FWORCH/import.pm
View file
Open in desktop

This file was deleted.

1,075 changes: 0 additions & 1,075 deletions roles/importer/files/importer/CACTUS/FWORCH/import/juniper.pm
View file
Open in desktop

This file was deleted.

1,796 changes: 0 additions & 1,796 deletions roles/importer/files/importer/CACTUS/FWORCH/import/phion.pm
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions roles/importer/files/importer/CACTUS/read_config.pm
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion roles/importer/files/importer/azure2022ff/azure_base.py
View file
Open in desktop

This file was deleted.

104 changes: 0 additions & 104 deletions roles/importer/files/importer/azure2022ff/azure_getter.py
View file
Open in desktop

This file was deleted.

121 changes: 0 additions & 121 deletions roles/importer/files/importer/azure2022ff/azure_network.py
View file
Open in desktop

This file was deleted.

Loading