feat: filter architectures based on selected repositories (#38)#110
Open
Flex936 wants to merge 3 commits into
Open
feat: filter architectures based on selected repositories (#38)#110Flex936 wants to merge 3 commits into
Flex936 wants to merge 3 commits into
Conversation
### Key Changes: - **Package Search (CachyOS#38):** - Added `getAllowedArchitectures` helper to dynamically filter architecture options based on selected repositories. - Implemented auto-clearing of invalid architectures on repository seleciton. - Switched `FormEvent` to `SyntheticEvent` to resolve TypeScript deprecation warnings. - **Utils Logic:** - Refactored pagination logic in `utils.ts` to use `else if` for better readability and minor performance optimization. - **UI Enhancement:** - Updated `ThemeToggle` to show a checkmark next to the currently active theme. Fixes CachyOS#38
Member
|
In the ideal world would be nice to apply filters automatically based on the supported instructions... but it's a browser 🥲 |
Member
|
Could you please run the format script before I have a look? |
Member
|
There are several distinct changes in current PR. Would you be so kind as to separate them? |
Member
|
Thanks for splitting the changes. I had a quick look and it's as complex as I feared it would need to be. Since it needs to be bi-directional from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
getAllowedArchitectureshelper to dynamically filter architecture options based on selected repositories.Fixes #38