Skip to content

Fix incorrect behavior BBR(2) with fq_codel#112

Merged
ptr1337 merged 3 commits intoCachyOS:masterfrom
ventureoo:bbr-hotfix
May 28, 2023
Merged

Fix incorrect behavior BBR(2) with fq_codel#112
ptr1337 merged 3 commits intoCachyOS:masterfrom
ventureoo:bbr-hotfix

Conversation

@ventureoo
Copy link
Member

Our kernels are defaulting to use FQ_CODEL queueing mechanism and it does not pairs well with BBR2 (our default packet scheduler), even on BBR2 source codes it says that it needs plain FQ with pacing so it works as it should, codel does not support pacing and it brings a lot of packet overhead etc, i was testing plain FQ and BBR2 works a lot better now, even pacman feels faster and steam well it works as it should.

All credit goes to @aarrayy.

@ventureoo ventureoo requested review from ptr1337 and sirlucjan May 28, 2023 15:15
@ventureoo
Copy link
Member Author

Don't merge for now. I found a better way to do it.

@ventureoo ventureoo marked this pull request as draft May 28, 2023 15:30
@ventureoo ventureoo marked this pull request as ready for review May 28, 2023 15:42
@ventureoo
Copy link
Member Author

The commit 67b2f41 has a more secure way of not accidentally affecting other network algorithms. It can be merged.

Copy link
Member

@sirlucjan sirlucjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptr1337 ptr1337 merged commit 8fc13a4 into CachyOS:master May 28, 2023
@ventureoo ventureoo deleted the bbr-hotfix branch May 29, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants