Skip to content

Fix icelake marches#83

Closed
danog wants to merge 2 commits intoCachyOS:masterfrom
nicelocal:master
Closed

Fix icelake marches#83
danog wants to merge 2 commits intoCachyOS:masterfrom
nicelocal:master

Conversation

@danog
Copy link

@danog danog commented Nov 29, 2024

The icelake march actually doesn't exist, only the icelake-server and icelake-client variants exist.

@ptr1337
Copy link
Member

ptr1337 commented Nov 29, 2024

Good catch, would you mind also to upstream the patch to the official architecutre repository from graysky?

@ptr1337
Copy link
Member

ptr1337 commented Nov 29, 2024

@danog
Copy link
Author

danog commented Nov 29, 2024

@ptr1337 Sure, but actually, I don't really like the current approach of arch selection at all: I consider this to be a hotfix, because there is a large number of arches supported by both rustc and gcc/clang that isn't listed here; the best solution should just be something autogenerated, but there are some subarch-dependent config flags that are a bit cryptic and I can't quite tell how they could be autogenerated.

For example, I was thinking of completely dropping all MARCH variants (except for a few like the amd ones that require -mno-tbm), and specifying a string config flag that allows passing in raw rust/C compilation flags (which would be really neat to work with in combination with https://github.com/hartwork/resolve-march-native, and would allow further optimization like l1/2-cache-size flags & so on).

However, this may not work well with configs like X86_L1_CACHE_SHIFT, X86_INTEL_USERCOPY, X86_USE_PPRO_CHECKSUM, unless there's a simple way to extract the correct value for those config flags from the compilation flags generated by resolve-march-native (also the rustflags can be a bit problematic, but for the time being I think we could just copy just the -march from the custom cflags without any other option, they mostly coincide)...

(also ping @graysky2)

@danog
Copy link
Author

danog commented Nov 29, 2024

I made this PR since I personally need optimized builds specifically for icelake-server, zen2/3/4 and alderlake, but a more universal solution would be much better I think...

Copy link
Member

@sirlucjan sirlucjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this patch error:

patch: **** malformed patch at line 514: + help

@danog
Copy link
Author

danog commented Nov 29, 2024

This should do it

@sirlucjan
Copy link
Member

Yes, thanks.

@1Naim
Copy link
Member

1Naim commented Nov 29, 2024

CachyOS/linux@a1cc72e Queued for the next sync. Expect to see this in the repository some time next week. Thank you.

@1Naim 1Naim closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants