Repository navigation
Typings incorrectly suggest that Rule.conditions is a setter #419
Description
Rule.conditions is described as being a setter, and is also used as such in one of the tests. But doing this and then running the engine leads to a RuleResult that, when JSON-stringified, will throw an error. (This is because a Rule expects its conditions to be an instance of Condition.)
Activity
CacheControl#419 change test to use setter method
CacheControl#419 add test for 'wrong' way to set conditions
CacheControl#419 update types to mark Rule.conditions as readonly
emilefokkemanavara commentedon Jun 25, 2025
@chris-pardy What do you think?
Merge pull request #420 from emilefokkemanavara/issue/419/rule-condit…