Skip to content

improve selecting qt module #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

almarklein
Copy link
Contributor

@almarklein almarklein commented Nov 28, 2019

It looks like this is currently the best fork in the quamash-asyncqt lineage to push improvements. Thanks for having a go at maintaining this well-needed lib :)

This PR:

  • Allows setting QT_API to empty string to to let qasync choose a lib. (Ran into this because QT_API was set, and needed to "unset" it).
  • Prefer a Qt lib if it is already imported.

@TheGreatCabbage TheGreatCabbage merged commit 8471972 into CabbageDevelopment:master Nov 28, 2019
@TheGreatCabbage
Copy link
Member

Thanks for your contribution! This is now live in qasync==0.9.3.

@almarklein almarklein deleted the qt_api_env branch November 29, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants