-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
policy docs: warn about filters and forwarding
We've been notified about possibility of "cache poisoning" this way, so let's document this drawback to make the expectations clearer.
- Loading branch information
Showing
1 changed file
with
14 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed is a potential issue, and we have conducted the actual cache poisoning attack with this issue.
Everyone using the filter
policy.suffix
should notice this issue.Moreover, we hope Knot will fix the issue in the next major version as soon as possible.
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, we have a huge ticket the policy rewrite, and I believe that the current plans of the design will also mitigate this (incidentally): https://gitlab.nic.cz/knot/knot-resolver/-/issues/535
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! When do you guys plan to implement the new designed policy modules?
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an old prototype, and I certainly plan to spend lots of time on this in the following few months.
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs change was merged, by the way.
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have noticed it in the latest document version. Thanks for your assistance.
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, have you guys started the rewriting process?
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started? Well, yes I could say that. But in the past couple of months it got stalled due to more immediate concerns taking more work.
Anyway, you can follow that branch: https://gitlab.nic.cz/knot/knot-resolver/-/compare/master...new-policy
ccb9d97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice