This repository has been archived by the owner on May 27, 2024. It is now read-only.
WIP: Minify CSS and JS for pagespeed/loading performance #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add frontend-maven-plugin to install local npm/nodejs + Add package.json for gulp-related dependencies + Add gulpfile.js for maven build tasks to generate otp.min.js and otp.min.css Replace CSS and JS with minified versions in index.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt at minifying css/js resulted in a CSS regression where the size of e.g the gps icon was too wide. That is fixed in this branch, but more testing needs to be done to ensure nothing else is broken.