Use Rcpp's stop and warning functions#2
Merged
kongdd merged 1 commit intoCUG-hydro:masterfrom Jan 23, 2026
Merged
Conversation
24 tasks
Member
|
Thanks for your PR. It looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides warning and error handlers that use Rcpp's warning and stop functions respectively.
This is particularly important for the case of errors, because calling
Rf_errordirectly prevents stack unwinding, and therefore memory leaks may happen. See this issue for further discussion.At Rcpp, we plan to warn about this usage, and at some point stop the compilation with an error message. Therefore, we kindly ask you to apply this patch and send an update to CRAN at your earliest convenience.