Add target to build the Abseil C++ library. #379
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that at this time support of the library is considered unstable and we disable -Werror for cheri-capability-misuse.
qwattash
force-pushed
the
abseil-target
branch
from
3f3e883
to
308077f
Compare
arichardson
reviewed
Oct 16, 2023
| # Enable tests for debug builds but not for production builds. | ||
| # In this way, the production version will have rtti. | ||
| if self.build_type.is_debug: | ||
| self.CXXFLAGS.append("-fno-rtti") |
There was a problem hiding this comment.
Why is this only under debug?
There was a problem hiding this comment.
I think the library works fine without -fno-rtti, the tests are triggering the build error with RTTI though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that at this time support of the library is considered unstable and we disable -Werror for cheri-capability-misuse.