Skip to content

Features #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Features #33

merged 3 commits into from
Feb 12, 2025

Conversation

Nortamo
Copy link
Collaborator

@Nortamo Nortamo commented Feb 12, 2025

  • Automatically determine host os for base container
  • Warn when group setting fails, and don't stop the installation
  • Activate venv when forcing conda to be active

Logic for venv activation:

  • An existing conda-containerize installation is used to create a venv.
  • If no variables are set, the venv will be active (not by explicit activation but by the virtue of being called -> equivalent by python standard ) in the container but the conda environment will not be in PATH.
  • Setting CW_FORCE_CONDA_ACTIVATE will first activate the conda environment and then the virtual env on startup
    (This was done to reduce the complexity of manually shuffling around the PATH entries)
  • The use case where you would want for both the venv and conda to be in PATH but for the conda environment not to be active is not considered or supported.

@Nortamo Nortamo merged commit 697d2af into master Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant