Upstream merge Source2Ze/CS2Fixes -> CS2ModServer/CS2Fixes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce2ZE#341) * feat: always weapon skins * feat: ``SF_PLAYEREQUIP_ONLYSTRIPSAME`` for ``game_player_equip`` * type 😅 * attempt to fix Source2ZE#189 * pre merge * refactor: weapon commands * Fix duplicate unhook * Some fixes Still unable to make GetPawn() work through CCSPlayer_ItemServices for some strange reason * Move virtual functions to CPlayerPawnComponent * Fix weapon purchases through AWS not getting selected * null check * Fix issues with weapon vectors being modified during iteration * Implement missed ONLYSTRIPSAME check in TriggerForActivatedPlayer --------- Co-authored-by: Vauff <mctehkitti@gmail.com> Co-authored-by: xen <xen@momentum-mod.org>
- Improve readability by using a dash instead of NONE in c_who for no flags - Display unauthenticated clients in c_who as such instead of just listing them without flags - Split c_listdc output into multiple ClientPrints, since new line characters mess up copying from console
- Make leader commands show up for active leaders in c_help
- Hopefully fix cs2f_leader_max_* cvars do what they say they do - Add cvar for score given to leaders instead of just setting it
Since a DELETE macro is already defined in the windows build environment, it can't be used. Instead, change naming format to only capitalize the first letter to keep the 5 function names consistent with each other.
Still need to migrate all the fake cvars, of which there's A LOT
- Add a null warning comment to g_pGameRules as well - Fix grammar in !nomlist when a map only has 1 nomination
Ported from CSSFixes/CSGOFixes, recently appeared in mako_v6. This bug is now in 3 Counter-Strike games across 2 different engines!
m_size bounds were only checked once and could be exceeded
Properly get name lengths for names with unicode characters. Unfortunately some unicode characters (Chinese) aren't monospaced, so even with correct length they wont line up cleanly
Moving away from the mp_weapons_allow_* cvars requires a lot more work, so these workarounds need to stay in place for now
These have actually been out of date for a while
* refactor knoback system * adjust something * Fix weapon lookup --------- Co-authored-by: Vauff <mctehkitti@gmail.com>
- Make c_extend print an client-only error for 0 minutes - Move logic for counting vote extends used into CVoteManager::ExtendMap, so external uses outside of CVoteManager have the option of modifying m_iExtends. There are no current uses in repository of this, but is meant for private use of forcing an extend vote to pass during map tests and might as well be in the public repo. - Make CVoteManager::ExtendMap taking negative iMinutes always directly subtract from mp_timelimit regardless of bAllowExtraTime (since it never adds 'extra' time, so logically shouldn't apply here). Realistically this has no impact, as before and after cases of this happening both still result in no time left even if mp_timeleft values differ.
Not properly tested
WARNING: Still mostly to fix plugin startup, cs2f_fix_game_bans is still untested and likely borked
# Conflicts: # CS2Fixes.vcxproj.filters # gamedata/cs2fixes.games.txt # src/cs2_sdk/entity/services.h # src/cs2fixes.cpp # src/events.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.