-
Notifications
You must be signed in to change notification settings - Fork 52
feat: cli.py collision name on eodag #1991 #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pdavid-cssopra
wants to merge
1
commit into
develop
Choose a base branch
from
feat-1991-cli-collision-name-on-eodag
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5317c47 to
a3f6f44
Compare
Contributor
Collaborator
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: b4cfda9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
1d565b9 to
d9eba42
Compare
5e7cb9d to
e6787cc
Compare
e6787cc to
a1395bc
Compare
Collaborator
Code Coverage (Windows)DetailsDiff against developResults for commit: b4cfda9 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
0353ea9 to
504547b
Compare
504547b to
519d0ac
Compare
~ eodag.cli:eodag > eodag.cli:eodag_cli ~ update setup.cfg ~ update tests + streadify cli test + explicit test syspath + explicit test bootstrap
519d0ac to
b4cfda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve collision on name "eodag", is module and cli root object "eodag"
Proposal: remane cli root function as "eodag_cli":
def eodag_cli(ctx: Context, verbose: int) -> None:
[...]
@eodag_cli.command
[...]
if name == "main":
eodag_cli(obj={})
By fixing tests, see some lack on syspath / bootstrap set, it fixed.
Steadify cli test by ensure assert on each command line
Fix eoproduct test to be able to validate PR
test_eoproduct.py:482
Progressbar has a temporal behaviour, then depens of 100ms passed, progress_callback.n can be ==0 or ==1
By waiting de safe duration to ensure progress bar completed, test is safe now
Test concurency troubleshot:
Config files are manipulated from multiple instance of EODataAccessGateway, from multiple test thread, have to steadify concurency manage.