fix: update config for CLMS global collections #1985
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
Code Coverage (Ubuntu)DetailsDiff against developResults for commit: ad42469 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
|
Code Coverage (Windows)DetailsDiff against developResults for commit: ad42469 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Collaborator
Author
|
currently there is an issue with collection CLMS_GLO_DMP_333M - the search result contains incorrect items. It seems to be an issue on provider side -> waiting for feedback |
Collaborator
Author
workaround implemented |
sbrunato
requested changes
Jan 14, 2026
eodag/resources/providers.yml
Outdated
Comment on lines
3385
to
3387
| id: | ||
| - '{{"productIdentifier": "{id}"}}' | ||
| - '$.id' |
Collaborator
There was a problem hiding this comment.
what's the point of having this conf for id ?
When the collection is also set, productIdentifier will come from its conf. And when it is not set, search will not be performed because dataset_id is missing
Collaborator
Author
There was a problem hiding this comment.
For searching by id but I realised that it does not work because it is overwritten witht the default value. I also noticed a strange behaviour of the date filter on wekeo side -> waiting for feedback on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration on
wekeofor the CLMS global collections has changed: Instead of having one dataset per collection, there is one dataset for all collections which can be filtered byproductTypeandproductIdentifierto get the data for a specific collection.Also fixes value of the processing:level for S5P_L1B_IR_ALL.