Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elic_cat_add_data() function #64

Merged
merged 36 commits into from
Dec 15, 2024
Merged

Add elic_cat_add_data() function #64

merged 36 commits into from
Dec 15, 2024

Conversation

sgvignali
Copy link
Collaborator

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.58506% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/cat_add_data.R 99.16% 1 Missing ⚠️
Files with missing lines Coverage Δ
R/cat_start.R 100.00% <ø> (ø)
R/cont_add_data.R 100.00% <100.00%> (ø)
R/cont_get_data.R 100.00% <100.00%> (ø)
R/cont_plot.R 100.00% <100.00%> (ø)
R/cont_start.R 100.00% <ø> (ø)
R/elic_cat.R 100.00% <100.00%> (ø)
R/utils.R 100.00% <100.00%> (ø)
R/cat_add_data.R 99.16% <99.16%> (ø)

sgvignali
sgvignali commented Dec 11, 2024
View reviewed changes
Copy link
Collaborator Author

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maude-v could you please address my comments?

@maude-v
Copy link
Collaborator

maude-v commented Dec 11, 2024

@sgvignali could you please review the changes?

sgvignali
sgvignali commented Dec 11, 2024
View reviewed changes
sgvignali
sgvignali commented Dec 11, 2024
View reviewed changes
Copy link
Collaborator Author

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few more changes.

@maude-v maude-v self-requested a review December 12, 2024 12:53
sgvignali
sgvignali commented Dec 12, 2024
View reviewed changes
Copy link
Collaborator Author

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks grate 🚀

I have just a couple of suggestions.

@sgvignali sgvignali merged commit 9eff9a6 into main Dec 15, 2024
8 of 9 checks passed
@sgvignali sgvignali deleted the feature/cat_add_data branch December 15, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maude-v maude-v Awaiting requested review from maude-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgvignali @maude-v