Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions and plot #59

Merged
merged 18 commits into from
Dec 10, 2024
Merged

Add functions and plot #59

merged 18 commits into from
Dec 10, 2024

Conversation

maude-v
Copy link
Collaborator

@maude-v maude-v commented Dec 6, 2024

No description provided.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
R/cont_add_data.R 100.00% <ø> (ø)
R/cont_plot.R 100.00% <ø> (ø)

@maude-v maude-v self-assigned this Dec 6, 2024
Copy link
Collaborator

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this version much improved. There are some minor comments, please try to address them.

Copy link
Collaborator

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments please.

Merge branch 'main' into feature/readme
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@sgvignali
Copy link
Collaborator

Great, could you please solve the last remaining comment?

@maude-v maude-v requested a review from sgvignali December 10, 2024 11:16
Copy link
Collaborator

@sgvignali sgvignali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great now!

@maude-v
Copy link
Collaborator Author

maude-v commented Dec 10, 2024

Can we merge this with main?

@sgvignali sgvignali merged commit f6bbe05 into main Dec 10, 2024
9 checks passed
@sgvignali sgvignali deleted the feature/readme branch December 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants