Use int(G26_RETRACT_MULTIPLIER) in lieu of “4” in MeshValidationHandler.cpp #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start the Bed Mesh Validation Pattern with one of the Full Circle pads instead of the front left corner
Implement [FR]#301
Update fork to merge commits from upstream
|
Sorry - superceded by #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current function to Print (Mesh) Validation Pattern is implemented by submitting a G26 command to the planner buffer, with a series of switches defined.
The Q switch, which defines the G26_RETRACT_MULTIPLIER to be used by G26, is currently set to fixed value of “4”. This causes the validation pattern to print using a retraction length of 4mm and an unretract length of 5mm.
A note on the screen (Screen78) states that the function requires a system that can tolerate 6mm of retraction. Systems converted to an all-metal hotend should indeed not use retraction lengths much higher than 1mm, or they risk incurring a nozzle clog.
Some Community Firmware users may not be aware that they should not use higher retraction settings on their systems. Some may just not ”process” the note on the screen. (Don’t ask me how I know that🙄)
In the upstream Marlin GitHub history, MarlinFirmware#16511 introduced the variable G26_RETRACT_MULTIPLIER, to answer a user’s request to please, “ Allow to set retraction for UBL mesh test”. Marlin users can now define Q to be any fixed value between 0.05 and 15, in their own Configuration.h file, using that variable.
The CR6 Community Firmware overrides that parameter, by specifying a fixed value of 4 in MeshValidationHandler.cpp.
This Pull Request proposes instead that MeshValidationHandler.cpp be modified to use the Configuration.h parameter.
If a value of 4 should be the default setting for stock CR6 printers, then that parameter should be defined as 4.0, not 1.0, in Configuration.h.
Requirements
This request does not require or assume any particular hardware configuration. It does, however, seek to align the Community Firmware more closely with the design philosophy of upstream Marlin, which may help users who have multiple machines running Marlin.
Benefits
The benefit of this proposed change is that users can define the G26_RETRACT_MULTIPLIER parameter value of their choice, by modifying Configuration.h instead of having to find and modify MeshValidationHandler.cpp.
This should make the Print Validation Pattern function available to all users, including those who have since converted their printer to use an all-metal hotend.
Configurations
Uses the Configuration.h and Configuration_adv.h files included with the latest Release.
Related Issues
This solution is compatible with Issue #300, in the sense that
G26_RETRACT_MULTIPLIER can also be user-defined to be the value of the variable RETRACT_LENGTH defined as the default retraction length for FWRETRACT in Configuration_adv.h. (Which, btw, is currently 6.5mm)