-
Notifications
You must be signed in to change notification settings - Fork 14
feat!: Reference counted terms #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zrho
wants to merge
4
commits into
main
Choose a base branch
from
zrho/core-term-arc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2338 +/- ##
==========================================
- Coverage 82.14% 82.05% -0.09%
==========================================
Files 244 244
Lines 44270 44474 +204
Branches 40099 40303 +204
==========================================
+ Hits 36365 36494 +129
- Misses 5915 5970 +55
- Partials 1990 2010 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6f84739
to
5418648
Compare
305351b
to
81c5cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes core
Term
s immutable and shareable via reference counting.Term
s can now be cheaply copied. To allow for cheap equality checks and hash computations,Term
s cache their hash value, making it viable to storeTerm
s as keys in hash tables. ATerm
can be pattern matched by obtaining aTermEnum
viaTerm::get
.BREAKING CHANGE:
Term
is changed from an enum to a structure that hides the reference counting machinery. This changes the way thatTerm
s are created and consumed.