-
Notifications
You must be signed in to change notification settings - Fork 14
feat!: Accept outgoing ports in SimpleReplacement nu_out #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-rs-v0.16.0 #2151 +/- ##
======================================================
+ Coverage 83.01% 83.05% +0.04%
======================================================
Files 219 219
Lines 41331 41385 +54
Branches 37479 37533 +54
======================================================
+ Hits 34310 34372 +62
+ Misses 5194 5186 -8
Partials 1827 1827
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
947e74d
to
19098e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me, but I'm missing the broader context to tell if the thing itself is a good idea 😅 A second opinion on this might be useful
Co-authored-by: Mark Koch <48097969+mark-koch@users.noreply.github.com>
@aborgna-q, ok? 🙃 |
Looks great to me! |
Currently, SimpleReplacement stores its output boundary map nu_out by referring to nodes outside the deleted subgraph in the host graph. This forces the invalidation set of the replacements to include nodes past the output, forbidding simultaneous adjacent replacements. This PR fixes this by allowing the keys of `nu_out` (i.e. the ports on the output boundary of the subgraph) to be either incoming ports (as before), or outgoing ports (in which case this is equivalent to specifying the map on all incoming ports linked to the given outgoing ports). The latter is less general but covers most use cases and reduces the size of the invalidation set. Closes #2098 BREAKING CHANGE: Generalised arguments to [`SimpleReplacement::new`] and [`SimpleReplacement::map_host_output`] to allow for outgoing ports. Previous type signatures remain valid, however, type inference may fail. --------- Co-authored-by: Mark Koch <48097969+mark-koch@users.noreply.github.com>
Currently, SimpleReplacement stores its output boundary map nu_out by referring to nodes outside the deleted subgraph in the host graph. This forces the invalidation set of the replacements to include nodes past the output, forbidding simultaneous adjacent replacements.
This PR fixes this by allowing the keys of
nu_out
(i.e. the ports on the output boundary of the subgraph) to be either incoming ports (as before), or outgoing ports (in which case this is equivalent to specifying the map on all incoming ports linked to the given outgoing ports). The latter is less general but covers most use cases and reduces the size of the invalidation set.Closes #2098
BREAKING CHANGE: Generalised arguments to [
SimpleReplacement::new
] and [SimpleReplacement::map_host_output
] to allow for outgoing ports. Previous type signatures remain valid, however, type inference may fail.