feat: Make NodeHandle generic #2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-rs-v0.16.0 #2092 +/- ##
======================================================
- Coverage 83.15% 83.14% -0.02%
======================================================
Files 218 218
Lines 41923 41930 +7
Branches 38101 38108 +7
======================================================
Hits 34861 34861
- Misses 5257 5264 +7
Partials 1805 1805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aborgna-q
force-pushed
the
ab/generic-node-handle
branch
from
da3e470 to
e5f4294
Compare
cqc-alec
approved these changes
Apr 16, 2025
Merged
via the queue into
release-rs-v0.16.0
with commit Apr 16, 2025
6347756
24 of 25 checks passed
aborgna-q
added a commit
that referenced
this pull request
May 7, 2025
Adds a generic node type to the `NodeHandle` type. This is a required change for #2029. drive-by: Implement the "Link the NodeHandles to the OpType" TODO
This was referenced May 7, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic node type to the
NodeHandletype.This is a required change for #2029.
drive-by: Implement the "Link the NodeHandles to the OpType" TODO