feat!: Expand SimpleReplacement::ApplyResult type #2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/rewrite-trait #2085 +/- ##
======================================================
- Coverage 82.91% 82.90% -0.01%
======================================================
Files 217 217
Lines 41529 41536 +7
Branches 37707 37714 +7
======================================================
+ Hits 34433 34437 +4
- Misses 5292 5295 +3
Partials 1804 1804
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acl-cqc
reviewed
Apr 21, 2025
acl-cqc
reviewed
Apr 21, 2025
lmondada
force-pushed
the
feat/simplereplace-return
branch
2 times, most recently
from
855f60e to
4b836c9
Compare
lmondada
force-pushed
the
feat/simplereplace-return
branch
from
4b836c9 to
706a887
Compare
|
Given that we are delaying the merge of all breaking change PRs, I've chosen to merge this into #2070 and already resolve the merge conflict. |
|
Oh - sorry I didn't spot what you were doing here - I'd have suggested merging into the |
lmondada
added a commit
that referenced
this pull request
Apr 28, 2025
It is currently impossible to obtain the map from nodes in the replacement graph to newly inserted nodes in `self` from the `ApplyResult` type for `SimpleReplacement`. This PR fixes this. BREAKING CHANGE: The `ApplyResult` associated type of `SimpleReplacement` is now a custom struct. The deleted nodes returned previously can be obtained using the `result.deleted_nodes` field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently impossible to obtain the map from nodes in the replacement graph to newly inserted nodes in
selffrom theApplyResulttype forSimpleReplacement.This PR fixes this.
BREAKING CHANGE: The
ApplyResultassociated type ofSimpleReplacementis now a custom struct. The deleted nodes returned previously can be obtained using theresult.deleted_nodesfield.