feat!: don't assume "main"-function in dataflow + constant folding #1896

acl-cqc · 2025-01-29T12:16:15Z

Instead, move towards explicitly stating entry-points, in common with remove_dead_funcs and remove_dead_code in #1902

I've also tried to reorganise the code a bit better wrt. prepopulate_df_inputs as we can also handle Conditional and CFG nodes by using existing code, hence renaming to just prepopulate_inputs

BREAKING CHANGE: dataflow analysis on Module-rooted Hugrs will no longer accept input PartialValues for the main function, these should be passed to prepopulate_inputs instead. Also prepopulate_df_inputs is gone, again use prepopulate_inputs. ConstantFoldPass::with_inputs now takes the entry-point node as first parameter as well as the inputs to apply there.

hugrbot · 2025-01-29T12:21:58Z

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary


--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/inherent_method_missing.ron

Failed in:
Machine::prepopulate_df_inputs, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-passes/src/dataflow/datalog.rs:53

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/method_parameter_count_changed.ron

Failed in:
hugr_passes::const_fold::ConstantFoldPass::with_inputs now takes 3 parameters instead of 2, in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/const_fold.rs:82

codecov · 2025-01-29T12:23:31Z

Codecov Report

Attention: Patch coverage is 96.62921% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (408517d) to head (83662e7).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
hugr-passes/src/dataflow/datalog.rs	95.91%	2 Missing ⚠️
hugr-passes/src/const_fold.rs	96.15%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage   83.81%   83.82%           
=======================================
  Files         199      198    -1     
  Lines       38293    38307   +14     
  Branches    35103    35117   +14     
=======================================
+ Hits        32097    32112   +15     
+ Misses       4356     4355    -1     
  Partials     1840     1840

Flag	Coverage Δ
python	`92.38% <ø> (ø)`
rust	`83.05% <96.62%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

acl-cqc · 2025-01-29T12:31:51Z

hugr-passes/src/dataflow/datalog.rs

+            let mut p = in_values.into_iter().peekable();
+            // We must provide some inputs to the root so that they are Top rather than Bottom.
+            // (However, this test will fail for DataflowBlock or Conditional roots, i.e. if no
+            // inputs have been provided they will still see Bottom. We could store the "input"


This is a very long note to have as a "We could" comment, it'll probably just get out-of-date ;). Perhaps I should just do it now...

But supporting DataflowBlock/Case roots doesn't seem a high priority. Maybe I should just remove the comment??

I think it should remain. This is pretty subtle, I judge the utility of helping to understand why something that should work doesn't to be more than the annoyance of a comment it doesn't work when it does.

…tests fail

doug-q

Looks good to me Alan, thanks for this.

hugr-passes/src/dataflow/datalog.rs

doug-q · 2025-03-05T08:36:25Z

hugr-passes/src/const_fold.rs

-    /// Specifies any number of external inputs to provide to the Hugr (on root-node
-    /// in-ports). Each supersedes any previous value on the same in-port.
+    /// Specifies a number of external inputs to an entry point of the Hugr.
+    /// For Module-rooted Hugrs, `node` should be a FuncDefn child of the root.


Why exclude a FuncDefn that is not a child of the root?

Well, there's no way it could be called other than from nodes already in the Hugr, so I don't see the point? You could use prepopulate_inputs if you really wanted

So I think the answer is probably the latter - use prepopulate_inputs. Unless you really want to do DF analysis to decide whether to add new uses of a currently-unused function, which sounds a bit wild

hugr-passes/src/const_fold.rs

doug-q · 2025-03-05T10:03:03Z

@aborgna-q Requesting your review because I am already quite familiar with this, despite my innane questions above!

aborgna-q

LGTM. Next release will be breaking already, so we should be able to merge this now.

hugr-passes/src/const_fold.rs

aborgna-q · 2025-03-05T18:17:58Z

hugr-passes/src/const_fold.rs

+                }),
            )
-        });
+            .unwrap(); // TODO return error?


Yes please.
This does a partial check for the precondition in with_inputs, no?

Specifies a number of external inputs to an entry point of the Hugr.
For Module-rooted Hugrs, node should be a FuncDefn child of the root.
For non-Module-rooted Hugrs, node should be the root of the Hugr.

(here afaik there's no check that n is an entrypoint). Could have the check there and leave the unwrap here?

Very partial - it checks that it's not, say, an AliasDefn or some other useless node that could be a child of Module, but that's about it. I've added complete checks and error variants, or would be happy to leave out the EntryPointNotChildOfModule and EntryPointNotRoot checks. These checks are not tested, either - @doug perhaps you could pick that up...

Removed EntryPountNotChildOfModule and EntryPointNotRoot in c8fce24 with lots of docs changes instead.

## 🤖 New release * `hugr-model`: 0.17.1 -> 0.18.0 (⚠ API breaking changes) * `hugr-core`: 0.14.4 -> 0.15.0 (⚠ API breaking changes) * `hugr-llvm`: 0.14.4 -> 0.15.0 (⚠ API breaking changes) * `hugr-passes`: 0.14.4 -> 0.15.0 (⚠ API breaking changes) * `hugr`: 0.14.4 -> 0.15.0 (✓ API compatible changes) * `hugr-cli`: 0.14.4 -> 0.15.0 (⚠ API breaking changes) ### ⚠ `hugr-model` breaking changes ```text --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_missing.ron Failed in: enum hugr_model::v0::ModelError, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:698 enum hugr_model::v0::Term, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:598 enum hugr_model::v0::ListPart, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:669 enum hugr_model::v0::Operation, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:452 enum hugr_model::v0::TuplePart, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:660 enum hugr_model::v0::ExtSetPart, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:678 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_missing.ron Failed in: function hugr_model::v0::text::parse, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/text/parse.rs:41 function hugr_model::v0::text::print_to_string, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/text/print.rs:14 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/module_missing.ron Failed in: mod hugr_model::v0::text, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/text/mod.rs:1 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron Failed in: struct hugr_model::v0::text::ParsedModule, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/text/parse.rs:34 struct hugr_model::v0::RegionScope, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:551 struct hugr_model::v0::VarId, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:354 struct hugr_model::v0::Param, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:689 struct hugr_model::v0::NodeId, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:322 struct hugr_model::v0::TermId, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:340 struct hugr_model::v0::Symbol, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:582 struct hugr_model::v0::text::ParseError, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/text/parse.rs:830 struct hugr_model::v0::LinkId, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:349 struct hugr_model::v0::Module, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:358 struct hugr_model::v0::Node, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:430 struct hugr_model::v0::LinkIndex, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:328 struct hugr_model::v0::RegionId, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:334 struct hugr_model::v0::Region, previously in file /tmp/.tmpuOV2md/hugr-model/src/v0/mod.rs:530 ``` ### ⚠ `hugr-core` breaking changes ```text --- failure method_requires_different_generic_type_params: method now requires a different number of generic type parameters --- Description: A method now requires a different number of generic type parameters than it used to. Uses of this method that supplied the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/method_requires_different_generic_type_params.ron Failed in: hugr_core::hugr::views::sibling_subgraph::SiblingSubgraph::try_from_nodes_with_checker takes 0 generic types instead of 1, in /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/views/sibling_subgraph.rs:234 hugr_core::hugr::views::SiblingSubgraph::try_from_nodes_with_checker takes 0 generic types instead of 1, in /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/views/sibling_subgraph.rs:234 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron Failed in: struct hugr_core::extension::prelude::Lift, previously in file /tmp/.tmpuOV2md/hugr-core/src/extension/prelude.rs:883 struct hugr_core::extension::prelude::LiftDef, previously in file /tmp/.tmpuOV2md/hugr-core/src/extension/prelude.rs:831 --- failure trait_associated_type_added: non-sealed public trait added associated type without default value --- Description: A non-sealed trait has gained an associated type without a default value, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_associated_type_added.ron Failed in: trait associated type hugr_core::hugr::internal::HugrInternals::Node in file /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/internal.rs:30 --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_method_added.ron Failed in: trait method hugr_core::hugr::internal::HugrInternals::get_pg_index in file /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/internal.rs:42 trait method hugr_core::hugr::internal::HugrInternals::get_node in file /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/internal.rs:45 --- failure trait_requires_more_generic_type_params: trait now requires more generic type parameters --- Description: A trait now requires more generic type parameters than it used to. Uses of this trait that supplied the previously-required number of generic types will be broken. To fix this, consider supplying default values for newly-added generic types. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_requires_more_generic_type_params.ron Failed in: trait HugrNodeRef (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/views/petgraph.rs:187 --- failure type_requires_more_generic_type_params: type now requires more generic type parameters --- Description: A type now requires more generic type parameters than it used to. Uses of this type that supplied the previously-required number of generic types will be broken. To fix this, consider supplying default values for newly-added generic types. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/type_requires_more_generic_type_params.ron Failed in: Struct HugrNodeRef (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-core/src/hugr/views/petgraph.rs:187 ``` ### ⚠ `hugr-llvm` breaking changes ```text --- failure feature_missing: package feature removed or renamed --- Description: A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature. ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/feature_missing.ron Failed in: feature typetag in the package's Cargo.toml feature pathsearch in the package's Cargo.toml feature serde in the package's Cargo.toml feature serde_json in the package's Cargo.toml ``` ### ⚠ `hugr-passes` breaking changes ```text --- failure function_requires_different_generic_type_params: function now requires a different number of generic type parameters --- Description: A function now requires a different number of generic type parameters than it used to. Uses of this function that supplied the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_requires_different_generic_type_params.ron Failed in: function ensure_no_nonlocal_edges (0 -> 1 generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:32 function ensure_no_nonlocal_edges (0 -> 1 generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:32 function nonlocal_edges (0 -> 1 generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:14 function nonlocal_edges (0 -> 1 generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:14 function partial_from_const (1 -> 2 generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/dataflow.rs:93 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_missing.ron Failed in: Machine::prepopulate_df_inputs, previously in file /tmp/.tmpuOV2md/hugr-passes/src/dataflow/datalog.rs:51 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/method_parameter_count_changed.ron Failed in: hugr_passes::const_fold::ConstantFoldPass::with_inputs now takes 3 parameters instead of 2, in /tmp/.tmpgXR84S/hugr/hugr-passes/src/const_fold.rs:82 --- failure trait_associated_type_added: non-sealed public trait added associated type without default value --- Description: A non-sealed trait has gained an associated type without a default value, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_associated_type_added.ron Failed in: trait associated type hugr_passes::dataflow::ConstLoader::Node in file /tmp/.tmpgXR84S/hugr/hugr-passes/src/dataflow.rs:63 --- failure trait_requires_more_generic_type_params: trait now requires more generic type parameters --- Description: A trait now requires more generic type parameters than it used to. Uses of this trait that supplied the previously-required number of generic types will be broken. To fix this, consider supplying default values for newly-added generic types. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_requires_more_generic_type_params.ron Failed in: trait NonLocalEdgesError (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:26 trait ConstLocation (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/dataflow.rs:44 --- failure type_requires_more_generic_type_params: type now requires more generic type parameters --- Description: A type now requires more generic type parameters than it used to. Uses of this type that supplied the previously-required number of generic types will be broken. To fix this, consider supplying default values for newly-added generic types. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/type_requires_more_generic_type_params.ron Failed in: Enum NonLocalEdgesError (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/non_local.rs:26 Enum ConstLocation (0 -> 1 required generic types) in /tmp/.tmpgXR84S/hugr/hugr-passes/src/dataflow.rs:44 ``` ### ⚠ `hugr-cli` breaking changes ```text --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_missing.ron Failed in: variant CliError::HUGRLoad, previously in file /tmp/.tmpuOV2md/hugr-cli/src/lib.rs:49 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_pub_field_missing.ron Failed in: field hugr_args of struct ValArgs, previously in file /tmp/.tmpuOV2md/hugr-cli/src/validate.rs:18 field hugr_args of struct MermaidArgs, previously in file /tmp/.tmpuOV2md/hugr-cli/src/mermaid.rs:17 --- warning enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_missing.ron Failed in: enum hugr_cli::PackageOrHugr, previously in file /tmp/.tmpuOV2md/hugr-cli/src/lib.rs:83 --- warning struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron Failed in: struct hugr_cli::HugrArgs, previously in file /tmp/.tmpuOV2md/hugr-cli/src/lib.rs:57 ``` <details><summary>Changelog</summary> ## `hugr-model` <blockquote> ## [0.18.0](hugr-model-v0.17.1...hugr-model-v0.18.0) - 2025-03-14 ### Bug Fixes - Hugr-model using undeclared derive_more features ([#1940](#1940)) ### New Features - *(hugr-model)* [**breaking**] Add `read_from_reader` and `write_to_writer` for streaming reads and writes. ([#1871](#1871)) - `hugr-model` AST ([#1953](#1953)) ### Refactor - *(hugr-model)* Reexport `bumpalo` from `hugr-model` ([#1870](#1870)) </blockquote> ## `hugr-core` <blockquote> ## [0.15.0](hugr-core-v0.14.4...hugr-core-v0.15.0) - 2025-03-14 ### New Features - [**breaking**] Add associated type Node to HugrView ([#1932](#1932)) - Rewrite for inlining a single Call ([#1934](#1934)) - [**breaking**] replace `Lift` with `Barrier` ([#1952](#1952)) - `hugr-model` AST ([#1953](#1953)) - Add float <--> int bytecasting ops to conversions extension ([#1956](#1956)) - Add collections.static_array extension. ([#1964](#1964)) - [**breaking**] Generic HUGR serialization with envelopes ([#1958](#1958)) ### Refactor - [**breaking**] remove unused dependencies ([#1935](#1935)) - *(hugr-model)* Reexport `bumpalo` from `hugr-model` ([#1870](#1870)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.15.0](hugr-llvm-v0.14.4...hugr-llvm-v0.15.0) - 2025-03-14 ### Bug Fixes - Rename widen insta tests ([#1949](#1949)) ### New Features - [**breaking**] Add associated type Node to HugrView ([#1932](#1932)) - Emit `widen` ops from the int ops extension ([#1946](#1946)) - [**breaking**] replace `Lift` with `Barrier` ([#1952](#1952)) - *(hugr-llvm)* Emit narrow ops ([#1955](#1955)) - Add float <--> int bytecasting ops to conversions extension ([#1956](#1956)) - *(hugr-llvm)* Emit iu_to_s and is_to_u ([#1978](#1978)) ### Refactor - [**breaking**] remove unused dependencies ([#1935](#1935)) </blockquote> ## `hugr-passes` <blockquote> ## [0.15.0](hugr-passes-v0.14.4...hugr-passes-v0.15.0) - 2025-03-14 ### New Features - [**breaking**] Add associated type Node to HugrView ([#1932](#1932)) - add separate DCE pass ([#1902](#1902)) - [**breaking**] replace `Lift` with `Barrier` ([#1952](#1952)) - [**breaking**] don't assume "main"-function in dataflow + constant folding ([#1896](#1896)) </blockquote> ## `hugr` <blockquote> ## [0.15.0](hugr-v0.14.4...hugr-v0.15.0) - 2025-03-14 ### New Features - add separate DCE pass ([#1902](#1902)) - [**breaking**] don't assume "main"-function in dataflow + constant folding ([#1896](#1896)) - [**breaking**] Add associated type Node to HugrView ([#1932](#1932)) - Rewrite for inlining a single Call ([#1934](#1934)) - [**breaking**] replace `Lift` with `Barrier` ([#1952](#1952)) - `hugr-model` AST ([#1953](#1953)) - Add float <--> int bytecasting ops to conversions extension ([#1956](#1956)) - Add collections.static_array extension. ([#1964](#1964)) - [**breaking**] Generic HUGR serialization with envelopes ([#1958](#1958)) ### Refactor - *(hugr-model)* Reexport `bumpalo` from `hugr-model` ([#1870](#1870)) - [**breaking**] remove unused dependencies ([#1935](#1935)) </blockquote> ## `hugr-cli` <blockquote> ## [0.15.0](hugr-cli-v0.14.4...hugr-cli-v0.15.0) - 2025-03-14 ### New Features - [**breaking**] Generic HUGR serialization with envelopes ([#1958](#1958)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>

acl-cqc requested a review from a team as a code owner January 29, 2025 12:16

acl-cqc requested a review from doug-q January 29, 2025 12:16

acl-cqc commented Jan 29, 2025

View reviewed changes

acl-cqc force-pushed the acl/dataflow_no_main branch from 733de9c to 9f477b0 Compare January 29, 2025 17:17

acl-cqc changed the base branch from main to acl/const_fold_dce January 29, 2025 17:17

acl-cqc changed the title ~~feat!: remove implicit "main"-function support from dataflow analysis~~ feat!: don't assume "main"-function in dataflow + constant folding Jan 29, 2025

acl-cqc mentioned this pull request Feb 3, 2025

fix: const-folding Module keeps at least "main" #1901

Merged

acl-cqc marked this pull request as draft February 3, 2025 16:51

acl-cqc changed the base branch from acl/const_fold_dce to main February 3, 2025 16:51

acl-cqc mentioned this pull request Feb 3, 2025

feat: separate DeadCodeElimPass, fix constant-folding of Modules #1897

Closed

acl-cqc added 6 commits March 4, 2025 15:50

dataflow: populate_(df_=>)inputs, do not look for 'main' - compiles, …

c54378b

…tests fail

Fix handling of in_values passed to run() via two-level HashMap

92aa4f2

note about join

c9077a9

docs

e17c4e8

const_fold: with_inputs takes target node

1062e70

GC find_main

4b68677

acl-cqc force-pushed the acl/dataflow_no_main branch from 0f621a6 to 4b68677 Compare March 4, 2025 15:57

Doc in_values to run

47a37f3

acl-cqc marked this pull request as ready for review March 4, 2025 16:45

doug-q reviewed Mar 5, 2025

View reviewed changes

doug-q requested a review from aborgna-q March 5, 2025 10:02

aborgna-q added the breaking-change Changes that break semver label Mar 5, 2025

aborgna-q reviewed Mar 5, 2025

View reviewed changes

doug-q added this to the Hugr v0.15 milestone Mar 11, 2025

acl-cqc added 3 commits March 12, 2025 17:59

comments

494b960

Check EntryPoint legality in const_fold.rs

ea8fc90

Use map_err

22c2866

Don't rule out non-module/root entrypoints; docs

c8fce24

doug-q self-assigned this Mar 13, 2025

doug-q added 2 commits March 13, 2025 08:40

fmt

16b5839

Merge branch 'main' of gh:CQCL-DEV/hugr into acl/dataflow_no_main

83662e7

doug-q requested review from aborgna-q and doug-q and removed request for doug-q March 13, 2025 10:16

aborgna-q approved these changes Mar 13, 2025

View reviewed changes

doug-q added this pull request to the merge queue Mar 13, 2025

Merged via the queue into main with commit 5b89677 Mar 13, 2025
25 checks passed

doug-q deleted the acl/dataflow_no_main branch March 13, 2025 16:06

hugrbot mentioned this pull request Mar 13, 2025

chore: release #1936

Merged

This was referenced Mar 18, 2025

chore: release #1993

Closed

chore: release #2002

Merged

feat!: don't assume "main"-function in dataflow + constant folding #1896

feat!: don't assume "main"-function in dataflow + constant folding #1896

Uh oh!

Conversation

acl-cqc commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugrbot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-q left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doug-q commented Mar 5, 2025

Uh oh!

aborgna-q left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

acl-cqc commented Jan 29, 2025 •

edited

Loading

hugrbot commented Jan 29, 2025 •

edited

Loading

codecov bot commented Jan 29, 2025 •

edited

Loading