Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature branch for hugr_model/serialization #1446

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feature branch for hugr_model/serialization #1446

wants to merge 9 commits into from

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Aug 20, 2024

No description provided.

zrho and others added 6 commits August 15, 2024 12:08
…#1442)

Updated edge representation. Instead of edges referring to their input
and output ports, ports now refer to the id of the edges that they are
connected to. This saves some space, and guarantees that each port is
part of only one edge.
@hugrbot
Copy link
Collaborator

hugrbot commented Aug 20, 2024

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

No release type found in pull request title "feature branch for hugr_model/serialization". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 58.51064% with 117 lines in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (c7cd840) to head (54bc650).

Files Patch % Lines
hugr-core/src/export.rs 58.36% 110 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
- Coverage   87.66%   87.28%   -0.38%     
==========================================
  Files         120      121       +1     
  Lines       20702    20983     +281     
  Branches    17949    18230     +281     
==========================================
+ Hits        18148    18315     +167     
- Misses       1785     1892     +107     
- Partials      769      776       +7     
Flag Coverage Δ
python 91.31% <ø> (ø)
rust 86.67% <58.51%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants