Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emission for CallIndirect nodes #73

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

mark-koch
Copy link
Contributor

Closes #10

@mark-koch mark-koch requested a review from a team as a code owner August 16, 2024 12:40
@aborgna-q aborgna-q changed the title feat: Emission for CallIndirect nodes feat!: Emission for CallIndirect nodes Aug 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (21b6105) to head (740040b).

Files Patch % Lines
src/emit/ops.rs 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   82.50%   82.59%   +0.09%     
==========================================
  Files          17       17              
  Lines        2258     2287      +29     
  Branches     2258     2287      +29     
==========================================
+ Hits         1863     1889      +26     
- Misses        257      258       +1     
- Partials      138      140       +2     
Flag Coverage Δ
rust 82.59% <86.20%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mark-koch mark-koch changed the title feat!: Emission for CallIndirect nodes feat: Emission for CallIndirect nodes Aug 16, 2024
@mark-koch mark-koch added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 042ad5d Aug 16, 2024
9 checks passed
@mark-koch mark-koch deleted the feat/call-indirect branch August 16, 2024 12:55
This was referenced Aug 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
## 🤖 New release
* `hugr-llvm`: 0.2.0 -> 0.2.1

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.2.1](v0.2.0...v0.2.1) -
2024-08-19

### Documentation
- Remove fixed crate version in usage instructions
([#68](#68))

### New Features
- Add lowering for LoadFunction
([#65](#65))
- Emission for CallIndirect nodes
([#73](#73))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement emission for CallIndirect Nodes.
3 participants