fix(tests-benchmark): apply overhead_per_contract in test_mixed_sload_sstore; fix JUMPI gas
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for per-contract loop setup/teardown overhead: - SLOAD loop: MSTORE init + JUMPDEST + condition check (23 gas) - SSTORE loop: MSTORE selector + MSTORE init + JUMPDEST + condition (26 gas) - Total: 49 gas per contract This aligns with the approach used in test_sload_empty_erc20_balanceof and test_sstore_erc20_approve.
CPerezz
approved these changes
Jan 8, 2026
Owner
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
Thanks a lot and apologies for the mess...
CPerezz
merged commit bc026bb
into
CPerezz:feat/update-stateful-benches-osaka
1 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need these two small last changes? 🙏