Repository navigation
Bike Shop - #52
Open
yaakov1001 wants to merge 5 commits into
Open
Bike Shop#52yaakov1001 wants to merge 5 commits into
yaakov1001 wants to merge 5 commits into
Conversation
astrohlicpu
self-requested a review
September 23, 2024 20:36
astrohlicpu
suggested changes
Sep 23, 2024
astrohlicpu
left a comment
astrohlicpu
left a comment
Contributor
There was a problem hiding this comment.
Very nice job. Please see comments. The reports are perfect.
| BikeColor varchar(15) not null constraint c_Shop_bike_color_cannot_be_blank check(BikeColor > ''), | ||
| DatePurchased date not null constraint c_Shop_date_purchased_must_be_on_or_after_March_1_2022 check(DatePurchased >= '03-01-2022'), | ||
| PurchasePrice decimal(6,2) not null, | ||
| NewOrUsed varchar(4) not null constraint c_Shop_new_or_used_only_allows_new_or_used check(NewOrUsed in ('new', 'used')), |
Contributor
There was a problem hiding this comment.
New or used can be made into a bit.
astrohlicpu
reviewed
Nov 3, 2024
astrohlicpu
left a comment
astrohlicpu
left a comment
Contributor
There was a problem hiding this comment.
Great job! Well done.
astrohlicpu
approved these changes
Nov 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.