Add ability to add to shares database #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SailSlick
force-pushed
the
r/announce_local
branch
from
9c41c7a
to
54e1f04
Compare
|
force push to rebase |
Closed
CianLR
approved these changes
Mar 11, 2019
services/database/share_servicer.py
Outdated
| req.article_id | ||
| ) | ||
| except sqlite3.Error as e: | ||
| self._db.commit() |
There was a problem hiding this comment.
This looks kind of similar to mine, I recently rethought how to handle the error and changed this to self._db.discard_cursor() which should disregard the changes
Merged
|
I moved the duplicated section between the posts servicer and the share servicer a lot. Tried merging the posts stuff with the share system so every post would hold the same stuff. It ended up a lot nastier so i went with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28