Mei export v2 #347
Mei export v2 #347
Conversation
…efs in the begining of the piece.
…plets, Ties, Grace notes, and correct namespace.
| with TemporaryDirectory() as tmpdir: | ||
| tmp_mei = os.path.join(tmpdir, "test.mei") | ||
| save_mei(import_score, tmp_mei) | ||
|
|
There was a problem hiding this comment.
I approve this way of testing, but I would add at least one extra test with a different more standard score from our musicxml test scores. The EXAMPLE_MEI is somehow a very weird score
There was a problem hiding this comment.
I had some problems with making more tests in particular I got some conflicts from MEI import. More of them are related to renaming of the IDs during import. Although the note IDs are consistent in the exported MEI, the IDs during the MEI import change based on a namespace variable (self.ns). I will leave it to you if you want to make some changes in the import function.
There was a problem hiding this comment.
Test is added with commit e108dc9. However, note id checking is omitted.
There was a problem hiding this comment.
uhm...ok I will look into that!
NOTE: Handling ids in MEI import is weird and non-consistent.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #347 +/- ##
===========================================
- Coverage 85.23% 84.96% -0.27%
===========================================
Files 81 82 +1
Lines 13921 14236 +315
===========================================
+ Hits 11865 12096 +231
- Misses 2056 2140 +84 ☔ View full report in Codecov by Sentry. |
MEI export (first simple version)
This method exports mei without full support for all elements as musicxml supports.
partitura.merge_parts(maybe can this be changed)xml:id