Skip to content

[DDING-000] 페이지네이션 조회 시 조건 수정 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

KoSeonJe
Copy link
Collaborator

@KoSeonJe KoSeonJe commented Nov 16, 2024

🚀 작업 내용

soft delete된 엔터티 조회하지 않도록 조건 수정했습니다

Summary by CodeRabbit

  • 새로운 기능
    • 삭제되지 않은 문서 및 공지만 검색하도록 쿼리 로직 수정.
  • 버그 수정
    • 삭제된 문서 및 공지가 검색 결과에 포함되지 않도록 필터링 추가.

Copy link

coderabbitai bot commented Nov 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

DocumentRepositoryNoticeRepository 인터페이스의 findAllByPage 메서드에서 SQL 쿼리에 조건이 추가되었습니다. 두 인터페이스 모두 deleted_at이 NULL인 경우만 결과에 포함되도록 필터링하는 WHERE 절이 추가되어, 삭제되지 않은 문서 및 공지사항만 검색되도록 쿼리 로직이 변경되었습니다. 메서드의 구조와 매개변수는 변경되지 않았습니다.

Changes

파일 경로 변경 요약
src/main/java/ddingdong/ddingdongBE/domain/documents/repository/DocumentRepository.java findAllByPage 메서드의 SQL 쿼리에 WHERE deleted_at IS NULL 조건 추가
src/main/java/ddingdong/ddingdongBE/domain/notice/repository/NoticeRepository.java findAllByPage 메서드의 SQL 쿼리에 WHERE deleted_at IS NULL 조건 추가

Possibly related PRs

Suggested labels

D-3

Suggested reviewers

  • 5uhwann
  • wonjunYou

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KoSeonJe KoSeonJe merged commit 0e00950 into develop Nov 16, 2024
1 check was pending
@KoSeonJe KoSeonJe deleted the fix/DDING-000 branch November 16, 2024 09:15
@KoSeonJe KoSeonJe self-assigned this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant