Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change data source to API repo #878

Merged
merged 2 commits into from
May 20, 2020

Conversation

kevee
Copy link
Member

@kevee kevee commented May 19, 2020

Description

This adds the real API endpoint to the race project dashboard. Notes:

  • It uses data from ./_api which is a cloned repo
  • You must run npm run setup or to not wipe your envvars, npm run setup:api-repo to clone the data
  • Some fields (duplicates) have changed, I updated the big GraphQL query, but didn't do QA on everything

Related Issues

@netlify
Copy link

netlify bot commented May 19, 2020

This is a preview version of the site.

Built with commit 5561481

https://deploy-preview-878--upbeat-lovelace-3e9fff.netlify.app

@calibre-analytics
Copy link

calibre-analytics bot commented May 19, 2020

Comparing chore: Change data source to API repo Snapshot #4 to median since last deploy of The COVID Tracking Project.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
90
from 94
1.5s
from 710ms
4.7s
from 3.4s
Chrome Desktop
Chrome • Cable
97
from 100
990ms
from 450ms
2.5s
from 1.5s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
82
from 87
1.7s
from 1.1s
5.9s
from 5s

2 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Total JSON size in bytes
MotoG4, 3G connection
48 KB
from 130 KB
Total JSON size in bytes
Chrome Desktop
48 KB
from 120 KB
Total JavaScript size in bytes
Chrome Desktop
1000 KB
from 720 KB
Total JavaScript size in bytes
MotoG4, 3G connection
1000 KB
from 720 KB
 Data page

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
First Contentful Paint
Chrome Desktop
1.6s
from 490ms
Speed Index
Chrome Desktop
1.7s
from 500ms
First Meaningful Paint
Chrome Desktop
1.6s
from 500ms
Largest Contentful Paint
Chrome Desktop
1.6s
from 500ms
Time to Interactive
Chrome Desktop
3.9s
from 2s

7 other significant changes: First CPU Idle on Chrome Desktop, Total JSON size in bytes on Chrome Desktop, Total JavaScript size in bytes on Chrome Desktop, Total JavaScript size in bytes on MotoG4, 3G connection, Total JSON size in bytes on MotoG4, 3G connection, Total Page size in bytes on MotoG4, 3G connection, Total Page size in bytes on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings

package.json Outdated Show resolved Hide resolved
@schwartzadev
Copy link
Collaborator

It looks like two things changed:

  1. Notes are now coming through as empty strings
  2. Something with the Disp flags is mixed up

image
i.e. for Black or African American alone, this is not a disparity (6% = 6%), but this PR makes it seem like one.

@kevee kevee merged commit 4214170 into feature/crdt-dashboard May 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the kevee/crdt-dashboard-source branch May 20, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants