Keep single pipeline definition for PR and release #719
Conversation
vifactor
force-pushed
the
single-pipeline
branch
2 times, most recently
from
e3e8f73 to
f829a23
Compare
|
This almost works, except that it somehow misses x86 Mac artifact, although the corresponding jobs are there... |
| name: Create release | ||
| runs-on: ubuntu-24.04 | ||
| needs: [ buildMac, buildMacOSQt6, buildUbuntu, buildWindows ] | ||
| if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
Putting all in one big file and run it with an if condition does not remove any boiler plate code.
Where is the benefit ?
There was a problem hiding this comment.
having one pipeline file instead of two (which must be kept in sync) has obvious benefits IMO. last release showed why it was bad.
I dont see this issue happening, either that or I'm missing the problem. screenshot please? |
https://github.com/COVESA/dlt-viewer/releases/tag/2.29.0-alpha3 |
Gotcha, let me look into it and see whats going on. |
|
@vifactor issue is corrected. macOS13 and macOS15 artifacts upload |
#701 Adjust createRelease to match naming conventions Signed-off-by: Viktor Kopp <vifactor@gmail.com>
Update macOS 13 artifact upload Update macOS x86 artifact name Signed-off-by: Viktor Kopp <vifactor@gmail.com>
vifactor
force-pushed
the
single-pipeline
branch
from
cf5b849 to
9d36b33
Compare
looks good! thanks! |
#701