Fix VERSION when being zero. #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vifactor
reviewed
Aug 4, 2025
LocutusOfBorg
force-pushed
the
fix-version
branch
3 times, most recently
from
d1e2abe to
dcd96a7
Compare
This fixes a regression in all variables being reset if one is zero instead of not defined -- COVESA DLT Viewer version: 2.29.0 -- COVESA DLT Viewer version: 0.0.0 With this fix: -- COVESA DLT Viewer version: 2.29.0 -- COVESA DLT Viewer version: 2.29.0
LocutusOfBorg
force-pushed
the
fix-version
branch
3 times, most recently
from
0edd5b9 to
602e298
Compare
LocutusOfBorg
force-pushed
the
fix-version
branch
from
602e298 to
ca41000
Compare
vifactor
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in all variables being reset if one is zero instead of not defined
-- COVESA DLT Viewer version: 2.29.0
-- COVESA DLT Viewer version: 0.0.0
With this fix:
-- COVESA DLT Viewer version: 2.29.0
-- COVESA DLT Viewer version: 2.29.0