Skip to content

Conversation

@alexmucde
Copy link
Collaborator

Remove Focal Debian Configuration.

Remove Focal Debian Configuration.

Signed-off-by: Alexander Wenzel <Alexander.AW.Wenzel@bmw.de>
@alexmucde
Copy link
Collaborator Author

Not the final version, but fixies some issues.

Still open issues:

  • DLT Viewer crashes when terminated
  • Plugins not automatically found, need to set Plugins path manually
  • No Icon visible

@alexmucde alexmucde merged commit 3f5fde0 into master Aug 1, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from ToDo to Done in COVESA DLT Viewer Aug 1, 2025
@alexmucde alexmucde deleted the fix_noble_debian_package branch August 1, 2025 08:00
@vifactor
Copy link
Collaborator

vifactor commented Aug 3, 2025

@alexmucde actually before these changes, plugins were found automatically (at least on my machine)

@vifactor
Copy link
Collaborator

vifactor commented Aug 4, 2025

@alexmucde is there any specific reason why you decided to place those OSS plugins into /usr/share instead of /user/bin? this actually broke their discoverability. It is of course possible to fix, but I have hard time to come up with nice solution

@alexmucde
Copy link
Collaborator Author

@vifactor This was the place where they plugins were before with qmake and qt5. /usr/bin/plugins is not a good place in a Linux system. /usr/share/dlt-viewer/plugins should be the right one. With Qt5 it was finding the plugins, but with qt6 it does not find them anymore. Need to fix it in the source code.

@alexmucde
Copy link
Collaborator Author

@vifactor

It uses the Path

#ifndef PLUGIN_INSTALLATION_PATH
#define PLUGIN_INSTALLATION_PATH ""
#endif

It was set before with qmake. We must set it also with cmake.

In Windows it must be "plugins" and in Linux "/usr/share/dlt-viewer/plugins"

Or i hard code it in the source code dependent on Linux or Windows? MacOs must be also considered?

@vifactor
Copy link
Collaborator

vifactor commented Aug 4, 2025

I know about that variable and how it was passed via qmake. It is just I found only messy ways to fix the plugins discovery, because as you correctly point out, cmake is used by other OSs so it is tricky to make it right and not break things (which are not tested on CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants