HighLight and Jump to Missing Messages #666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Btw, the commits are a mess. Please can you rebase to master ? |
Collaborator
|
@Renu-Priya411 Please move both functions from Mainwindow into plugin. Plugin gets access to all DLTMsgs in initMsg function, when DLt file is loaded. There you can create the Map regarding the mcnt values. |
alexmucde
reviewed
Jul 9, 2025
src/mainwindow.cpp
Outdated
| } | ||
| } | ||
|
|
||
| project.ecu->clear(); |
Collaborator
There was a problem hiding this comment.
Check if this line was removed in master. Remove also if needed.
alexmucde
reviewed
Jul 9, 2025
src/mainwindow.cpp
Outdated
| * for MSVC compilers. | ||
| **/ | ||
| extern "C" { | ||
| #include "dlt_user.h" |
Collaborator
|
Please rebase to master and only Plugin should appear in the changed files. |
Collaborator
|
I have fixed the build and tried it out. |
Changes made for displaying only the missing messages Signed-off by : RenuPriya Krishnamoorthy <renupriya.ka.krishnamoorthy@partner.bmwgroup.com>
Export feature for dltCounter Plugin has been implemented Signed-off by : RenuPriya Krishnamoorthy <renupriya.ka.krishnamoorthy@partner.bmwgroup.com>
…s using the counter and the context ID values. The missing sequence of numbers will be visible in a new window. The data can be exported to local machine as well. Changes made in mainwindow.cpp, qdltcontrol and dltCounterPlugin Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@partner.bmwgroup.com>
Changes made for displaying only the missing messages Signed-off by : RenuPriya Krishnamoorthy <renupriya.ka.krishnamoorthy@partner.bmwgroup.com>
Export feature for dltCounter Plugin has been implemented Signed-off by : RenuPriya Krishnamoorthy <renupriya.ka.krishnamoorthy@partner.bmwgroup.com>
…s using the counter and the context ID values. The missing sequence of numbers will be visible in a new window. The data can be exported to local machine as well. Changes made in mainwindow.cpp, qdltcontrol and dltCounterPlugin Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@partner.bmwgroup.com>
The data is completely handled within the DLTCounterPlugin. Changes in mainwindow.cpp and qdltcontrol.cpp has been removed. Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Conflicts in mainwindow.cpp has been resolved Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Resolved the conflicts in mainwindow.cpp Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Changes in mainwindow.h Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Renu-Priya411
force-pushed
the
Feature-HighLightAndJumpToMissingMessages
branch
from
576ae20 to
4695188
Compare
Collaborator
please do it again @Renu-Priya411 |
The fileSaveDialog has been implemented. Jumping to previous or next message from the missing messages has been implemented. Conflicts has been fixed Signed-off by : Renu Priya Krishnamoorthy <RenuPriya.KA.Krishnamoorthy@bti.bmwgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.