Skip to content

Sync-Fix #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

Sync-Fix #44

wants to merge 39 commits into from

Conversation

carykees98
Copy link
Collaborator

Syncs are failing with code 10 or 30 more than they should be.

This PR aims to fix that problem as well as a few others:

  • Rsync password files were being read from the wrong place
  • Currently Rsync stdout and stderr are being discarded, at a minimum stderr should be written to a file if it contains anything to make identifying issues possible

carykees98 added 30 commits April 7, 2025 18:33
@carykees98
change location of secrets files
002f90e
@carykees98
add secrets directory to gitignore
27b57ec
@carykees98
fixed typo in JobManager
57a4b92
@carykees98
updating SyncDetails to work with new mirrors.json schema
5177906
@carykees98
updated format for SyncScheduer.cpp
ca303ea
@carykees98
updated JobManager to work with mirrors.json change
a0601c4
@carykees98
trying to figure out what is causing an error
bed3549
@carykees98
more debug
26f1bc3
@carykees98
debug again
9c9b699
@carykees98
maybe the fix?
b373b8f
@carykees98
more debug (wooo)
3989f30
@carykees98
moved command logging
784e5f6
@carykees98
debug and formatting update
5d6ce6b
@carykees98
libfmt cant format json, using dump instead
e15aa75
@carykees98
adding host, source, and dest shouldn't have been a nested loop
48de63f
@carykees98
debug print to see if fix worked
e7425fe
@carykees98
log stderr for failing rsync processes
20a49bb
@carykees98
close stdout and stderr pipes before removing job from active jobs map
981b588
@carykees98
removed extra qualification from write_stderr_to_file
635c809
@carykees98
write stdout and stderr instead of just stderr
7e9fbf3
@carykees98
don't use ioctl, just read into a buffer of size bufsiz
d47be4e
@carykees98
had been registering closed write end of pipe as read end
98dc3fd
@carykees98
last item in argv has to be nullptr
24fe5d4
@carykees98
updated warning for failed sync
c6a59cc
@carykees98
resize stream contents string after clearing it
fe9ae41
@carykees98
update compose files
7068c5f
@carykees98
fixed bug where all syncs would be interrupted if one timed out
308b28d
@carykees98
added zsh to sync scheduler docker file to run fedora sync
0d0d9ea
@carykees98
updated how stderr and stdout are written to files
464e2f3
@carykees98
added ability to manual sync all projects
0fa2877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carykees98