Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Responsive #185

Merged
merged 39 commits into from
Feb 16, 2024
Merged

Website Responsive #185

merged 39 commits into from
Feb 16, 2024

Conversation

PatchFact
Copy link
Contributor

@PatchFact PatchFact commented Jan 29, 2024

All pages save for history are fully responsive. Closes #166, #201, #198, #183.

@PatchFact PatchFact added the enhancement New feature or request label Jan 29, 2024
@PatchFact PatchFact added this to the Peer Review milestone Jan 29, 2024
@PatchFact PatchFact self-assigned this Jan 29, 2024
Copy link
Contributor

@kmalott kmalott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good! All pages are fully responsive and change as the size of the screen changes.

app/capstone/transformer/templates/navbar.html Outdated Show resolved Hide resolved
@Ferdinand737
Copy link
Contributor

image

We should not merge this until after the re-styled history and results pages are merged.
This branch still has the MultipleObjectsReturned at /history bug.

Copy link
Contributor

@Ferdinand737 Ferdinand737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History and store pages are broken
image
image

@Ferdinand737
Copy link
Contributor

Looks Awesome @PatchFact nice job!.

The only thing is that light theme does not work on profile page, we can deal with this another time.

@Ferdinand737 Ferdinand737 merged commit 510fbe4 into master Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make site responsive
3 participants