fix(video-upload): protect react-media-recorder hook from SSR #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connordoman
added
fix
tthvo
reviewed
Apr 4, 2024
tthvo
reviewed
Apr 4, 2024
tthvo
reviewed
Apr 4, 2024
|
Works well indeed! Thanks for handling this :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to PrivacyPal! 👋
Fixes: #799
Description of the change:
This change adds a wrapper module for
react-media-recorder-2to prevent the issue with theWorkerAPI not being present during SSR. It does so by dynamically importing the module if the browser context is detected.Motivation for the change:
While the
Worker is not definederror does not effect usage or even build & deployment, testing any route that contains<UploadVideoForm/>will irrevocably fail. This is because thereact-media-recorder-2module is imported at the top of the file, which causes the error to be thrown during the SSR process.