Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(welcome): Welcome page UI #736

Merged
merged 25 commits into from
Mar 27, 2024
Merged

feat(welcome): Welcome page UI #736

merged 25 commits into from
Mar 27, 2024

Conversation

linhnnk
Copy link
Contributor

@linhnnk linhnnk commented Mar 23, 2024

Welcome to PrivacyPal! 👋

Fixes: #698

Description of the change:

Change the UI for /.

Also added a Feedback form, when the user enters their email and feedback in the form, AWS SES will send the user's email and their feedback to an admin email.

I want to make an automatic confirmation email back to the user as well, i.e. We have received your feedback... or something like that, but for that I believe we need a domain to send emails to addresses that are not verified in AWS SES. If not possible, we can skip this.

Motivation for the change:

The previous home page is pretty monotonous. Should modify the home page to look like a welcome page to introduce the use of the website briefly.

@linhnnk linhnnk added feat New feature or request area/front-end Front-end work labels Mar 23, 2024
@linhnnk linhnnk self-assigned this Mar 23, 2024
@linhnnk linhnnk changed the title feat(welcome) Welcome page UI feat(welcome): Welcome page UI Mar 23, 2024
@linhnnk linhnnk marked this pull request as ready for review March 25, 2024 04:42
@tthvo tthvo added the high-priority Need immediate attention label Mar 26, 2024
@linhnnk
Copy link
Contributor Author

linhnnk commented Mar 26, 2024

@tthvo I just added the email credentials, do you mind checking?

app/web/Makefile Outdated Show resolved Hide resolved
app/web/package.json Outdated Show resolved Hide resolved
app/web/package.json Outdated Show resolved Hide resolved
app/web/Makefile Outdated Show resolved Hide resolved
app/web/src/lib/ses.ts Outdated Show resolved Hide resolved
tthvo
tthvo previously approved these changes Mar 26, 2024
Copy link
Contributor

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Awesome work!

@tthvo
Copy link
Contributor

tthvo commented Mar 26, 2024

Rebase again and resolve conflicts pls :))

@tthvo
Copy link
Contributor

tthvo commented Mar 26, 2024

Note that this will require changes to Helm Chart. Will look into it as soon as this is merged.

Copy link
Contributor

@connordoman connordoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the redesign! The gif on the front page is a great idea.

However, I don't have the font Inter installed on my system so I get this rendering error:

Screenshot 2024-03-26 at 11 44 27

We are importing Inter correctly in /layout.tsx so all that needs changing is adding a custom CSS variable name. From the Next.js font docs:

Screenshot 2024-03-26 at 11 47 48

@linhnnk linhnnk requested review from tthvo and connordoman and removed request for nganphan123 March 26, 2024 23:24
Copy link
Contributor

@connordoman connordoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love this

@tthvo tthvo merged commit b8d7257 into develop Mar 27, 2024
10 checks passed
@tthvo tthvo deleted the gh-698-welcome-page-ui branch March 27, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/front-end Front-end work feat New feature or request high-priority Need immediate attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants