feat(styles): styles & layout for VideoUploadUI #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connordoman
requested review from
MyStackOverflows,
nganphan123,
tthvo and
linhnnk
|
is this meant to merge onto |
Eventually by the transitive property I'll be right either way haha. Thanks man, early morning |
MyStackOverflows
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling for Video Upload UI
Resolves #70
Description of the change:
Added styling to
<VideoUploadUI/>mostly by altering its layout to use<Card/>components, like the<LoginForm/>. Also took this opportunity to unify styling across multiple components.We are still experimenting with the most appropriate method for addressing case-by-case styling. This time, common style rules for
<Card/>and some of its children are stored in a JavaScriptstyleobject and then retrieved where appropriate. This prevents site-wide overrides of elements like<Card/>but still allows us to manipulate certain ones to our needs.Motivation for the change:
Every component needs styling!