Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(nextjs-test): run NextJS unit tests in CI #60

Merged
merged 1 commit into from
Oct 30, 2023
Merged

ci(nextjs-test): run NextJS unit tests in CI #60

merged 1 commit into from
Oct 30, 2023

Conversation

tthvo
Copy link
Contributor

@tthvo tthvo commented Oct 30, 2023 •
edited
Loading

Signed-off-by: Thuan Vo thuan.votann@gmail.com

Related to #8

What's new

Run jest test suites on CI

@tthvo tthvo added feat New feature or request ci CI/Github Actions labels Oct 30, 2023
@tthvo tthvo force-pushed the gh-8-nextjs-tests branch 2 times, most recently from 6a9d7d4 to a53a1f0 Compare October 30, 2023 07:48
@tthvo tthvo self-assigned this Oct 30, 2023
MyStackOverflows
MyStackOverflows approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MyStackOverflows MyStackOverflows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks are passing, looks all good to me. not sure why branch main is included since we don't have a main branch but I guess main is the standard now so futureproofing == good

@MyStackOverflows MyStackOverflows mentioned this pull request Oct 30, 2023
Merged
@tthvo
Copy link
Contributor Author

tthvo commented Oct 30, 2023

Yeh mostly because Bowen is planning to move to main. So, in case she does, we will have very minimal change.

connordoman
connordoman approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@connordoman connordoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@tthvo tthvo merged commit ee669c0 into develop Oct 30, 2023
4 checks passed
@MyStackOverflows
Copy link
Contributor

Yeh mostly because Bowen is planning to move to main. So, in case she does, we will have very minimal change.

awesome! great work

@tthvo tthvo deleted the gh-8-nextjs-tests branch November 12, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connordoman connordoman connordoman approved these changes

@MyStackOverflows MyStackOverflows MyStackOverflows approved these changes

@linhnnk linhnnk Awaiting requested review from linhnnk

Assignees

@tthvo tthvo

Labels
ci CI/Github Actions feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tthvo @MyStackOverflows @connordoman