chore(db): split DATABASE_URL into component env vars #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
added
chore
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
tthvo
force-pushed
the
gh-25-prisma-url
branch
from
04e1429
to
5fbbafd
Compare
nganphan123
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to PrivacyPal! 👋
Related to #534
Related to #394
Description of the change:
Split
DATABASE_URLinto component env vars. This allows us to specify each env var in k8s deployment easily as helm does not offer a way to combine them.Motivation for the change:
Easier to integrate with k8s deployment and aws db custom resources.