-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(login): integrated login form component #47
Conversation
b5e5439
to
251ba64
Compare
I did git add --a but somehow that folder is not committed? Do you know how can I fix this problem? |
oh nevermind I got it! |
9683d73
to
46aede4
Compare
I extracted the header and footer elements Linh created and moved styling around as much as possible. Overriding patternfly base styles is working to some extent but we will have to go back and refactor component structure somewhat. This PR is rebased on #33 but has also had to refactor aspects of auth due to authorize calling Node modules from the client. We will have to reconsider |
ping @nganphan123 @linhnnk |
Rebase on |
93a69fd
to
7527d10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything works for me.
0516edc
to
3aba078
Compare
Hmm, I realized I was mentioning about idea of base64 the password quite vaguely. From a second look, the credentials are sent as JSON, correct? If so, we can leave it as it is then without base64. Otherwise, we will have to encode the entire JSON. Sorry, would trouble you to revert the latest commit. |
One more question: Does the login form pops up directly or do I have to click the bottom |
gotta click log in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Very nice!
Signed-off-by: Connor Doman connor@connordoman.dev
A simple username/password login form based on Patternfly.
Example page
To test this functionality, first ensure the
.env
prerequisites from #33 are met by running this command:Then run (from
front-end/
):npm install
npm run dev
You can then navigate to http://localhost:3000/login to test this form. You can use the following credentials:
Depends on #33