Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(videos): video upload status and review front end tests #466

Closed
wants to merge 8 commits into from

Conversation

connordoman
Copy link
Contributor

@connordoman connordoman commented Feb 5, 2024

Welcome to PrivacyPal! 👋

Fixes: #461
Depends on #499

Description of the change:

Adds Cypress front end tests for /upload/status and /upload/review

Motivation for the change:

We need tests!

@connordoman connordoman added area/front-end Front-end work test Unit/Integration tests labels Feb 5, 2024
@connordoman connordoman added this to the Term 2 Week 6 milestone Feb 5, 2024
@connordoman connordoman self-assigned this Feb 5, 2024
@connordoman connordoman changed the title tests(e2e): video upload status and review front end tests chore(tests): video upload status and review front end tests Feb 5, 2024
@connordoman connordoman force-pushed the gh-461-test-upload-status-and-review branch from 643aac3 to 4fb3d49 Compare February 5, 2024 02:01
@github-actions github-actions bot added the dependent Depending on other work label Feb 5, 2024
@tthvo tthvo changed the title chore(tests): video upload status and review front end tests test(videos): video upload status and review front end tests Feb 7, 2024
@COSC-499-W2023 COSC-499-W2023 deleted a comment from github-actions bot Feb 7, 2024
@tthvo tthvo removed the dependent Depending on other work label Feb 7, 2024
Copy link

This PR/issue depends on:

@connordoman
Copy link
Contributor Author

ping @linhnnk @nganphan123

Copy link
Contributor

@nganphan123 nganphan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been a couple of changes to the video review component as we moved to the new upload logic, so you might want to double-check when you rebase.

@MyStackOverflows
Copy link
Contributor

MyStackOverflows commented Apr 2, 2024

any reason why this is still here and not merged?

edit: oh duh this is pre-ui overhaul

@connordoman
Copy link
Contributor Author

@MyStackOverflows yeah i think i'll close this one for now

@connordoman connordoman closed this Apr 2, 2024
@tthvo tthvo deleted the gh-461-test-upload-status-and-review branch April 6, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/front-end Front-end work test Unit/Integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants