feat(video-api): add DELETE route for videos #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyStackOverflows
previously approved these changes
Jan 29, 2024
connordoman
dismissed stale reviews from MyStackOverflows and nganphan123
via
b077776
Signed-off-by: Connor Doman <domanc@student.ubc.ca>
nganphan123
previously approved these changes
Jan 31, 2024
MyStackOverflows
previously approved these changes
Feb 3, 2024
|
Hey @connordoman, would I bother you to bring the changes in #393 needed for this in a separate PR for review? |
|
Rebase pls :)) |
|
This PR/issue depends on: |
connordoman
dismissed stale reviews from MyStackOverflows and nganphan123
via
00eb775
MyStackOverflows
previously approved these changes
Feb 19, 2024
|
Rebase and resolve conflicts pls. |
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
tthvo
reviewed
Feb 23, 2024
|
|
||
| // delete the video from s3 | ||
| try { | ||
| deleteArtifact(videoRef, getOutputBucket()); |
There was a problem hiding this comment.
Following #560, the videoref in db can be under review or accepted. This means, in the case of videos being under review, deleting files in output bucket will leave files in input bucket stale/dangling.
There was a problem hiding this comment.
One way to go around this is to fetch the video tags from S3 first, check if it has privacypal-status tag. If so, also try to delete the video from input bucket.
Co-authored-by: Thuan Vo <thuan.votann@gmail.com> Signed-off-by: Connor Doman <connor@connordoman.dev>
tthvo
reviewed
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to PrivacyPal! 👋
Fixes: #411
Depends on #393
Depends on #403
Depends on #406
Depends on #388
Description of the change:
This change introduces an API route for deleting videos from S3 and the database.
Motivation for the change:
Clients and professionals need to be able to delete uploaded media as a matter of privacy.
Usage
DELETE /api/video/{awsRef}?appt={apptId}e.g.
DELETE /api/video/1-privacy-pal-test-20240128T170000-processed.mp4?apptId=123