Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appointments): appointment creation UI #210

Merged
merged 47 commits into from
Dec 4, 2023
Merged

Conversation

connordoman
Copy link
Contributor

Welcome to PrivacyPal! 👋

Fixes: #193

Description of the change:

Appointments can be created at /staff/appointment/new. Currently, any user is permitted to make appointments with any other user regardless of permission or if both attendees are the same User. For evaluation purposes I created a few new actions that:

  • create an appointment
  • list all clients
  • list all professionals
  • list all appointments for a user

These are fully subject to change and still require proper Role authorization.

Motivation for the change:

Professionals need to be able to create appointments.

Try it yourself:

First go to /staff/appointment/new and select the Client you're meeting with:

Screenshot 2023-11-30 at 2 50 45 PM

Then, because Clients are currently not restricted from creating appointments, you can view upcoming appointments at /user/dashboard:

Screenshot 2023-11-30 at 2 51 39 PM

@connordoman connordoman added feat New feature or request area/front-end Front-end work labels Nov 30, 2023
@connordoman connordoman added this to the Term 1 Week 13 ❗️ milestone Nov 30, 2023
@connordoman connordoman self-assigned this Nov 30, 2023
@MyStackOverflows
Copy link
Contributor

MyStackOverflows commented Dec 1, 2023

image
on /staff/appointment/new, selecting either user1 test or user2 test then clicking 'Submit' does this on my end

@MyStackOverflows
Copy link
Contributor

@connordoman any news/updates on this PR?

@connordoman
Copy link
Contributor Author

@MyStackOverflows should be working now. make sure your db schema is up to date and there should be no problem

@connordoman connordoman removed the request for review from nganphan123 December 3, 2023 22:18
@connordoman
Copy link
Contributor Author

ping @linhnnk

Copy link
Contributor

@MyStackOverflows MyStackOverflows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about the miscommunication, you're right it was a schema issue on my end facepalm
image
looks great!

@linhnnk
Copy link
Contributor

linhnnk commented Dec 4, 2023

I have this error, and cannot find any users from the list.

Screenshot from 2023-12-03 14-43-22
Screenshot from 2023-12-03 16-48-42

@connordoman
Copy link
Contributor Author

I have this error, and cannot find any users from the list.

Screenshot from 2023-12-03 14-43-22 Screenshot from 2023-12-03 16-48-42

@linhnnk you have to go to app/web/db/, run make start-db and make run and the database should start and be populated with sample users

linhnnk
linhnnk previously approved these changes Dec 4, 2023
Copy link
Contributor

@linhnnk linhnnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I got it! Looks good to me!

@tthvo
Copy link
Contributor

tthvo commented Dec 4, 2023

@connordoman rebase pls.

@tthvo
Copy link
Contributor

tthvo commented Dec 4, 2023

@linhnnk @MyStackOverflows check and review again pls

Copy link
Contributor

@MyStackOverflows MyStackOverflows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep all still works for me!

@tthvo tthvo merged commit cf0ce66 into develop Dec 4, 2023
8 checks passed
@tthvo tthvo deleted the gh-193-appointment-ui branch December 4, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/front-end Front-end work feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants