fix(videos): do not clean up input videos when cancelling #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm keeping the input video when the user may not retry with the same video might be a privacy concern though, due to uncensored videos being stored on the volume |
Yes! Then, the user will need to specify: retry same video, reject and redo or accept. Eventually, reject and accept is the final action. So, input videos will be cleaned anyway. |
MyStackOverflows
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to PrivacyPal! 👋
Related to #171
Description of the change:
Cancelling cleanup should ignore input files.
Motivation for the change:
Retrying processing (same video) can just reuse the same input files. NextJS can do the clean up when the video is accepted or rejected.