Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): add entrypoint script to init database #130

Merged
merged 2 commits into from
Nov 20, 2023
Merged

feat(db): add entrypoint script to init database #130

merged 2 commits into from
Nov 20, 2023

Conversation

tthvo
Copy link
Contributor

@tthvo tthvo commented Nov 20, 2023

Welcome to PrivacyPal! 👋

Fixes: #88

Description of the change:

  • Added entrypoint script to:
    • Initialize the database schema.
    • Populate User table if necessary (i.e. basic auth). Otherwise, truncate the table in a CASCADE mode.
  • Update Prisma version to 5.5.2 to match that in nextjs.

Motivation for the change:

See #88

@tthvo tthvo added feat New feature or request area/back-end Back-end work labels Nov 20, 2023
@tthvo tthvo self-assigned this Nov 20, 2023
@tthvo tthvo linked an issue Nov 20, 2023 that may be closed by this pull request
[Task] Postgres data population script #88
Closed
@nganphan123
Copy link
Contributor

@tthvo I think we should add a rule in the makefile in root folder to build all images (for nextjs server, db and video processor) at once.

This was referenced Nov 20, 2023
Closed
Closed
@tthvo
Copy link
Contributor Author

tthvo commented Nov 20, 2023

@tthvo I think we should add a rule in the makefile in root folder to build all images (for nextjs server, db and video processor) at once.

Good catch! I will do that in #139! Thanks!

nganphan123
nganphan123 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@nganphan123 nganphan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm! Tested the build process, everything works for me.

@tthvo tthvo merged commit cc0d5f3 into develop Nov 20, 2023
7 checks passed
@tthvo tthvo deleted the gh-88-add-data-seed-script branch November 20, 2023 10:01
@tthvo tthvo added the need-documentation Product documentation required label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nganphan123 nganphan123 nganphan123 approved these changes

Assignees

@tthvo tthvo

Labels
area/back-end Back-end work feat New feature or request need-documentation Product documentation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Postgres data population script
2 participants
@tthvo @nganphan123