Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump numpy from 1.24.4 to 1.26.2 in /app/video-processing #111

Merged
merged 2 commits into from
Nov 21, 2023
Merged

build(deps): bump numpy from 1.24.4 to 1.26.2 in /app/video-processing #111

merged 2 commits into from
Nov 21, 2023

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 13, 2023 •
edited by tthvo
Loading

Bumps numpy from 1.24.4 to 1.26.2.

Related to #140

Release notes

Sourced from numpy's releases.

1.26.2 release

NumPy 1.26.2 Release Notes

NumPy 1.26.2 is a maintenance release that fixes bugs and regressions discovered after the 1.26.1 release. The 1.26.release series is the last planned minor release series before NumPy 2.0. The Python versions supported by this release are 3.9-3.12.

Contributors

A total of 13 people contributed to this release. People with a "+" by their names contributed a patch for the first time.

  • @​stefan6419846
  • @​thalassemia +
  • Andrew Nelson
  • Charles Bousseau +
  • Charles Harris
  • Marcel Bargull +
  • Mark Mentovai +
  • Matti Picus
  • Nathan Goldbaum
  • Ralf Gommers
  • Sayed Adel
  • Sebastian Berg
  • William Ayd +

Pull requests merged

A total of 25 pull requests were merged for this release.

  • #24814: MAINT: align test_dispatcher s390x targets with _umath_tests_mtargets
  • #24929: MAINT: prepare 1.26.x for further development
  • #24955: ENH: Add Cython enumeration for NPY_FR_GENERIC
  • #24962: REL: Remove Python upper version from the release branch
  • #24971: BLD: Use the correct Python interpreter when running tempita.py
  • #24972: MAINT: Remove unhelpful error replacements from import_array()
  • #24977: BLD: use classic linker on macOS, the new one in XCode 15 has...
  • #25003: BLD: musllinux_aarch64 [wheel build]
  • #25043: MAINT: Update mailmap
  • #25049: MAINT: Update meson build infrastructure.
  • #25071: MAINT: Split up .github/workflows to match main
  • #25083: BUG: Backport fix build on ppc64 when the baseline set to Power9...
  • #25093: BLD: Fix features.h detection for Meson builds [1.26.x Backport]
  • #25095: BUG: Avoid intp conversion regression in Cython 3 (backport)
  • #25107: CI: remove obsolete jobs, and move macOS and conda Azure jobs...
  • #25108: CI: Add linux_qemu action and remove travis testing.
  • #25112: MAINT: Update .spin/cmds.py from main.
  • #25113: DOC: Visually divide main license and bundled licenses in wheels
  • #25115: MAINT: Add missing noexcept to shuffle helpers

... (truncated)

Commits
  • 03b6260 Merge pull request #25128 from charris/prepare-1.26.2
  • 6961f60 REL: Prepare for the NumPy 1.26.2 release
  • d81f0ae Merge pull request #25121 from charris/backport-25042
  • 766d5a8 BUG: ensure passing np.dtype to itself doesn't crash
  • cefdd34 Merge pull request #25120 from charris/backport-25063
  • ae77d67 Merge pull request #25119 from charris/backport-25090
  • 0035b44 BLD: change default of the allow-noblas option to true.
  • 12b7b35 BUG: Make n a long int for np.random.multinomial
  • 9887c9c Merge pull request #25118 from charris/backport-25051
  • 2359aec MAINT: Make bitfield integers unsigned
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added chore Refactor, clean up, rename, etc. dependencies Dependencies labels Nov 13, 2023
@dependabot dependabot bot force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from 6aa803c to 899f309 Compare November 13, 2023 09:47
@tthvo
Copy link
Contributor

tthvo commented Nov 13, 2023

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from 899f309 to e283060 Compare November 13, 2023 09:51
@dependabot Dependabot
Copy link
Author

dependabot bot commented on behalf of github Nov 13, 2023

Looks like this PR is already up-to-date with develop! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@tthvo
Copy link
Contributor

tthvo commented Nov 13, 2023

Looks like this requires a bump to python 3.9.

Source: https://github.com/COSC-499-W2023/year-long-project-team-1/actions/runs/6848292434/job/18618186928?pr=111

@MyStackOverflows
Copy link
Contributor

what would updating to 3.9 require on the build side? would you need to modify the makefile/dockerfile @tthvo? because if it's complicated or adds a significant bloat to the image size, I don't think it's really necessary as numpy is only directly used once in my code (for numpy array slicing), it's mostly there as a dependency for opencv.

@tthvo
Copy link
Contributor

tthvo commented Nov 15, 2023

For build, all I need is to update the base image tag to 3.9*. I guess its mostly on your end to ensure if other dependencies break when upgrading numpy.

@dependabot dependabot bot force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from e283060 to f82ac47 Compare November 20, 2023 05:23
MyStackOverflows
MyStackOverflows previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@MyStackOverflows MyStackOverflows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking through the changelog, can't see anything that would conflict or break our other dependencies

@MyStackOverflows
Copy link
Contributor

@tthvo rebase then merge?

@dependabot dependabot bot force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from f82ac47 to 1645f79 Compare November 20, 2023 21:34
@tthvo
Copy link
Contributor

tthvo commented Nov 20, 2023

@tthvo rebase then merge?

Yeh, but hold on. Will need to upgrade to higher python >= 3.9 first here.

@dependabot dependabot bot force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from 1645f79 to d22a2bf Compare November 20, 2023 21:37
@tthvo tthvo force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from d22a2bf to c81112a Compare November 20, 2023 21:44
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tthvo
Copy link
Contributor

tthvo commented Nov 20, 2023

Okayy @MyStackOverflows, upgraded to python 3.11 now. Ideally, 3.13 but not yet available to fedora or rhel.

@MyStackOverflows
Copy link
Contributor

unfortunately the newest official build of python3 for my OS is 3.9.5, I can add a non-official community build (from the deadsnakes PPA) but there's a chance that some of our packages/modules may not work with the non-official build
image

@tthvo
Copy link
Contributor

tthvo commented Nov 20, 2023

Thats unfortunate indeed. Since you are the maintainer of this component, I will just downgrade python to 3.9. We will aim for higher python later.

@tthvo tthvo force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch 2 times, most recently from a8a605e to 1bf8e08 Compare November 21, 2023 01:53
@tthvo
Copy link
Contributor

tthvo commented Nov 21, 2023

@dependabot rebase

@dependabot Dependabot
Copy link
Author

dependabot bot commented on behalf of github Nov 21, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@tthvo tthvo force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch 2 times, most recently from 444401c to 30490dd Compare November 21, 2023 07:48
@tthvo
Copy link
Contributor

tthvo commented Nov 21, 2023

Ping @MyStackOverflows. Downgraded to python 3.9 now.

@dependabot @tthvo
build(deps): bump numpy from 1.24.4 to 1.26.2 in /app/video-processing
b8676c8 
Bumps [numpy](https://github.com/numpy/numpy) from 1.24.4 to 1.26.2.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.24.4...v1.26.2)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@tthvo tthvo force-pushed the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch from 30490dd to f961c25 Compare November 21, 2023 08:26
MyStackOverflows
MyStackOverflows approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@MyStackOverflows MyStackOverflows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@tthvo tthvo merged commit 27913dc into develop Nov 21, 2023
7 checks passed
@dependabot dependabot bot deleted the dependabot/pip/app/video-processing/develop/numpy-1.26.2 branch November 21, 2023 09:13
@tthvo tthvo mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyStackOverflows MyStackOverflows MyStackOverflows approved these changes

Assignees
No one assigned
Labels
chore Refactor, clean up, rename, etc. dependencies Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @MyStackOverflows