Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ghcr.io): add instructions for pull images from ghcr.io #109

Merged
merged 1 commit into from
Nov 12, 2023
Merged

docs(ghcr.io): add instructions for pull images from ghcr.io #109

merged 1 commit into from
Nov 12, 2023

Conversation

tthvo
Copy link
Contributor

@tthvo tthvo commented Nov 11, 2023

Welcome to PrivacyPal! 👋

Related to #5

Description of the change:

Add some instructions on how to pull container images from ghcr.io.

How to test

Once authenticated, try pull privacypal image:

podman pull ghcr.io/cosc-499-w2023/privacypal:0.1.0-alpha.2

@tthvo
docs(ghcr.io): add instructions for pull images from ghcr.io
9a5a23d 
Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo added docs Improvements or additions to documentation build Build work (e.g. container images) labels Nov 11, 2023
@tthvo tthvo self-assigned this Nov 11, 2023
@tthvo
Copy link
Contributor Author

tthvo commented Nov 11, 2023

Hey @COSC-499-W2023/team-1, tagging for visibility.

connordoman
connordoman approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@connordoman connordoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. For docker compose do you just run docker compose login ghcr.io?

@tthvo
Copy link
Contributor Author

tthvo commented Nov 12, 2023

For docker compose do you just run docker compose login ghcr.io?

For docker, you would run docker login ghcr.io. The docker compose uses docker so pull operations should work.

@tthvo tthvo merged commit 744c388 into develop Nov 12, 2023
9 checks passed
@tthvo tthvo deleted the gh-5-ghcr-docs branch November 12, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connordoman connordoman connordoman approved these changes

Assignees

@tthvo tthvo

Labels
build Build work (e.g. container images) docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @connordoman