Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AuthService to return full response object in pingAdmin function and to only check for 200 response from ping-admin endpoint #423

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Oct 20, 2024

Description

This pr aims to HOT-FIX a slight issue that would occur with session checking for admins on web by only checking the status of the response instead of matching the response as well.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…tion and to only check for 200 response from ping-admin endpoint
@waveyboym waveyboym added type: bug Something isn't working type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr priority: low This does/did not need to be addressed any time soon effort: 1 This can be/was resolved in minutes platform: web/desktop This is related to web/desktop platforms labels Oct 20, 2024
@waveyboym waveyboym added this to the PROJECT DAY🎉🎨 milestone Oct 20, 2024
@waveyboym waveyboym self-assigned this Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.33%. Comparing base (3d59c7d) to head (47dc1e1).
Report is 2 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (3d59c7d) and HEAD (47dc1e1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3d59c7d) HEAD (47dc1e1)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #423       +/-   ##
============================================
- Coverage    87.21%   33.33%   -53.89%     
============================================
  Files           23        1       -22     
  Lines         5461        6     -5455     
  Branches       126        0      -126     
============================================
- Hits          4763        2     -4761     
+ Misses         596        4      -592     
+ Partials       102        0      -102     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit 2ec3c67 into develop Oct 20, 2024
7 of 8 checks passed
@waveyboym waveyboym deleted the fix/web/auth-session-issues branch October 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 1 This can be/was resolved in minutes platform: web/desktop This is related to web/desktop platforms priority: low This does/did not need to be addressed any time soon type: bug Something isn't working type: fix Introduces a fix for a previous issue type: security This is a security related issue/pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant